GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — Flag unused variables in multiple assignments in UseDeclaredVarsMoreThanAssignments by 0x000NULL · Pull Request #2227 · PowerShell/PSScriptAnalyzer ConversationPR Summary
Fixes #2164 How tested:
This only touches PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUseDeclaredVarsMoreThanAssignments only looked at assignments whose left-hand side is a single variable, so `$a, $b = $null` was never flagged. Treat each variable of an array literal on the left-hand side like a single-variable assignment, and stop at the first matching variable when checking whether a reference is the assignment itself. Fix PowerShell#2164
Ethan Aldrich (0x000NULL)
requested review from
a team and
Christoph Bergmeister (bergmeister)
as code owners
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Changes recommendedReference classification still mistakes repeated writes for uses and index reads for writes, producing missed and incorrect warnings. 2 open issuesWhat changed in this PRExtends Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Reassigning a variable from a multiple assignment, as in `$a, $b = 1, 2; $a = 3`, was counted as a use, unlike `$a = 1; $a = 3`. Variables read inside another target, as in `$i, $x[$i] = 0, 42`, were counted as writes, so `$i` was wrongly flagged.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Changes recommendedTyped targets in repeated assignments are misclassified as reads, suppressing valid unused-variable warnings. 1 open issue2 resolved since last reviewReview effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Comment on lines
+245
to
+246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
At least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. PSUseDeclaredVarsMoreThanAssignments and assigning multiple variables
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |