GeezerVison is showing github.com — Preserve CR-only line endings when formatting files by Copilot · Pull Request #2234 · PowerShell/PSScriptAnalyzer
Conversation
Copilot
AI
commented
Oct 23, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
CR-only scripts could fail during indentation inference because parser line numbers were matched against LF-only splits. The formatter also needs to retain CR-only separators throughout edits.
- Line handling: Split on CRLF, CR, or LF, and use the same splitting for indentation inference.
- Regression coverage: Add an in-place formatting test that checks CR-only line endings remain unchanged.
$script = "function foo {`r`t`$x=1`r}"
# Invoke-Formatter preserves the CR-only line endings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Copilot
AI
changed the title
[WIP] Fix code based on review comment for pull request 2230
Preserve CR-only line endings when formatting files
Oct 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
The focused changes consistently handle CR-only lines and include regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes CR-only line handling so the formatter can infer indentation correctly and preserve those line endings when formatting files.
Changes:
- Recognizes CRLF, CR, and LF separators through the shared line-splitting helper.
- Uses that helper for indentation inference.
- Adds an in-place CR-only regression test and makes the legacy-encoding fixture independent of the test file’s encoding.
| File |
Description |
| Tests/Engine/InvokeFormatter.tests.ps1 |
Verifies CR-only formatting output and saved contents; updates the legacy-encoding fixture. |
| Engine/Extensions.cs |
Splits text on CRLF, CR, or LF. |
| Engine/Commands/InvokeFormatterCommand.cs |
Uses shared line splitting for indentation inference. |
Review effort: Balanced
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|