GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve relative indentation in comment runs by Copilot · Pull Request #2236 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Comment runs lost relative indentation when correction clipped each comment line independently. Apply a shared shift constrained by the run’s least-indented line.

  • Behavior: Preserve indentation offsets across the full run, including when its first comment is not the least-indented.
  • Regression coverage: Add space- and tab-indented cases, such as:
        # inner
    # outer

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
546bc9f
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 26, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2237 October 26, 2026 10:05
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 26, 2026 10:05
View session
@bergmeister
Preserve indentation across comment runs
58b9a06
Co-authored-by: bergmeister <[email protected]>
Copilot AI changed the title [WIP] Fix code for review comment in pull request Preserve relative indentation in comment runs Oct 26, 2026
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 26, 2026 10:12
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 26, 2026 10:12
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2237 October 26, 2026 10:42
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 26, 2026 11:14
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 26, 2026 11:15
View session
Copilot AI reviewed Oct 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The localized change addresses the indentation loss with regression coverage for both indentation styles and no unresolved findings.

No open issues 🎉

What changed in this PR

This PR updates the indentation rule to preserve relative spacing within contiguous comment runs, even when the first comment is not the least-indented.

Changes:

  • Calculate comment offsets from the least-indented line in the full run.
  • Add regression cases for space and tab indentation.
File Description
Tests/​Rules/​UseConsistentIndentation.tests.ps1 Adds space- and tab-indented regression cases with a more-indented first comment.
Rules/​UseConsistentIndentation.cs Uses the run’s minimum starting column as the shared indentation baseline.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 26, 2026 11:18
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 26, 2026 11:18
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 0c2d630 into copilot/fix-psuseconsistentindentation-issue Oct 26, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/fix-code-based-on-review-comment branch October 26, 2026 11:18
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 26, 2026
Preserve relative indentation in commented-out code #2231
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.