GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue with preserving relative indentation in comments by Copilot · Pull Request #2253 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #2231. I've created this new PR, which merges into #2231, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #2231
Triggering comment (#2231 (comment)):

🔵 Needs a closer look

A multiline block-comment sequence followed by code can still join a standalone comment run incorrectly and alter its indentation.

No open issues 🎉

1 previously missed issue
In code that hasn't changed since last review

Medium severity Use the entire skipped comment group's end line for comparison
Rules/​UseConsistentIndentation.cs:512

NextTokenIgnoringComments can skip a block comment spanning additional lines, but this comparison uses only the first comment's end line. Inside an if block, a correctly indented # comment followed by unindented <# first #> <# second and then #> Write-Output 'value' is incorrectly grouped with that code-prefixed comment sequence, moving # comment from four to eight spaces. Compare against the end of the entire skipped comment group so comment-prefixed code stays outside the run.

1 resolved since last review

  • Medium severity Prevent repeated indentation of consecutive block comments

Review effort: Balanced

Copilot fix previously missed issue and create regression test for it. when finished open new PR for fix, if PR not possible push here directly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
417c714
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 27, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2254 October 27, 2026 13:57
Copilot AI mentioned this pull request Oct 27, 2026
Preserve relative indentation in commented-out code #2231
Open
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 13:57
View session
@bergmeister
Fix multiline comment group detection
79af79b
Co-authored-by: bergmeister <[email protected]>
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 14:07
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 27, 2026 14:07
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 27, 2026 14:14
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 14:15
View session
Copilot AI reviewed Oct 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow boundary correction addresses the reported issue and includes a matching regression test, with no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR refines the comment-run handling introduced in #2231 so comment-prefixed code does not alter the relative indentation of preceding standalone comments.

Changes:

  • Compare the following code’s start line against the end of the entire adjacent comment group.
  • Add a regression test covering multiple block comments spanning lines and followed by code.
File Description
Tests/​Rules/​UseConsistentIndentation.tests.ps1 Adds regression coverage for the reported comment-group boundary case.
Rules/​UseConsistentIndentation.cs Tracks the full comment group’s end line when detecting following code.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2254 October 27, 2026 14:31
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 27, 2026 14:31
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 27, 2026 14:31
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 067cbda into copilot/fix-psuseconsistentindentation-issue Oct 27, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/preserve-relative-indentation branch October 27, 2026 14:48
@bergmeister Christoph Bergmeister (bergmeister) changed the title [WIP] Fix issue with preserving relative indentation in comments Fix issue with preserving relative indentation in comments Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.