GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve relative indentation in commented-out code by Copilot · Pull Request #2257 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #2231. I've created this new PR, which merges into #2231, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #2231
Triggering comment (#2231 (comment)):

🔵 Needs a closer look

Inline comments after line-leading pipes can still join standalone comment runs and incorrectly shift pipeline indentation.

No open issues 🎉

1 previously missed issue
In code that hasn't changed since last review

Medium severity Exclude trailing comments from pipeline indentation offset calculation
Rules/​UseConsistentIndentation.cs:373

With PipelineIndentation = 'NoIndentation', a line-leading pipe's trailing comment reaches this scan and is incorrectly grouped with following standalone comments. For a function containing a four-space-indented, backtick-continued foo, then | # trailing, # standalone, and bar, formatting moves the pipe from column 5 to column 11. Exclude comments with code before them as well as code after them from run-offset calculation.

Review effort: Balanced

Copilot fix and add regression test. create new pr instead of pushing to this branch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Initial plan
4d7ae16
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 27, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2258 October 27, 2026 17:51
Copilot AI mentioned this pull request Oct 27, 2026
Preserve relative indentation in commented-out code #2231
Open
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 17:52
View session
@bergmeister
Exclude trailing pipe comments from comment runs
80e81ec 
Co-authored-by: bergmeister <[email protected]>
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 18:00
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 27, 2026 18:00
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 27, 2026 18:12
@bergmeister Christoph Bergmeister (bergmeister) changed the title [WIP] Preserve relative indentation in commented-out code Preserve relative indentation in commented-out code Oct 27, 2026
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 27, 2026 18:12
View session
Copilot AI reviewed Oct 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow guard addresses the reported defect with focused regression coverage; tests were not executed during review.

No open issues 🎉

What changed in this PR

This PR fixes a comment-run boundary case in PSUseConsistentIndentation, supporting #2231’s preservation of relative indentation in commented-out code.

Changes:

  • Exclude comments with preceding code on the same line from comment-run offset calculation.
  • Add a regression test for trailing comments after line-leading pipes, checking expected formatting and idempotence.
File Description
Tests/​Rules/​UseConsistentIndentation.tests.ps1 Tests the reported pipeline case with NoIndentation and repeat formatting.
Rules/​UseConsistentIndentation.cs Adds an early return for comments preceded by code on the same line.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2258 October 27, 2026 18:15
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 27, 2026 18:15
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 27, 2026 18:15
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 3f33813 into copilot/fix-psuseconsistentindentation-issue Oct 27, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/preserve-relative-indentation-comments branch October 27, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.