GeezerVison is showing github.com — Add pipeline comment indentation regression tests by Copilot · Pull Request #2260 · PowerShell/PSScriptAnalyzer
Conversation
Copilot
AI
commented
Oct 27, 2026
•
edited by bergmeister
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
Add regression coverage for comment-run indentation with IncreaseIndentationForFirstPipeline and IncreaseIndentationAfterEveryPipeline. The test verifies nested comment offsets, expected indentation through a second pipeline stage, analyzer cleanliness, and formatter idempotence. This test-only follow-up targets the head branch of #2231.
PR Checklist
- PR has a meaningful title
- Summarized changes
- Change is not breaking (test-only)
- Existing test file copyright header is retained
- Added regression tests
- PR is ready to merge (draft; awaiting CI)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
The focused test-only changes have no identified blocking issues, though CI results remain pending.
No open issues 🎉
What changed in this PR
Adds test-only regression coverage for pipeline comment indentation, extending #2231’s work to preserve relative indentation within comment runs.
Changes:
- Covers
IncreaseIndentationForFirstPipeline and IncreaseIndentationAfterEveryPipeline, including nested comment offsets and second-stage command indentation.
- Verifies no analyzer violations, unchanged formatter output, and formatter idempotence.
| File |
Description |
| Tests/Rules/UseConsistentIndentation.tests.ps1 |
Adds parameterized regression tests for comment-run indentation under both pipeline modes. |
Review effort: Balanced
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.