GeezerVison

With IgnoreOneLineBlock = $false, splitting a one-line if/else produced stray leading and trailing spaces, a } indented by 3 spaces, and a else with a leading space:

Invoke-Formatter -ScriptDefinition "if (`$RegEx) { '-match' } else { '-like' }" -Settings @{
    Rules = @{
        PSPlaceOpenBrace  = @{ Enable = $true; IgnoreOneLineBlock = $false }
        PSPlaceCloseBrace = @{ Enable = $true; IgnoreOneLineBlock = $false }
    }
}

if ($RegEx) {
 '-match' 
   }
 else {
 '-like' 
 }

if ($RegEx) {
'-match'
}
else {
'-like'
}

About the issue's expected output: these settings run only the two brace rules. PSPlaceCloseBrace.NewLineAfter defaults to $true, so it puts else on its own line, and none of the enabled rules indents the body (that's PSUseConsistentIndentation). The "After" column is therefore the correct result. The CodeFormattingOTBS preset with IgnoreOneLineBlock = $false now produces exactly the output the issue expected:

if ($RegEx) {
    '-match'
} else {
    '-like'
}

Changes

• PlaceOpenBrace, NewLineAfter correction: the correction extent now runs from { to the next token on the same line, so it also removes the whitespace after the brace.
• PlaceCloseBrace, BraceShouldBeOnNewLine correction: when the preceding token is on the same line, the extent now starts at that token's end, so it also removes the whitespace before }.
• PlaceCloseBrace.GetIndentation: the loop condition was k > 0, so it never checked the first token in the script. When the open brace was on the first line, } took its indentation from the 2nd token (( → 3 spaces). Changed to k >= 0. This also affects the NoEmptyLineBefore correction, which uses the same helper.
• PlaceCloseBrace, NewLineAfter correction: the extent now runs from } up to the branch keyword (else/elseif/catch/finally). The replacement is } + newline + the brace's indentation, so the keyword lines up with } and no leading space remains.

Tests

• Three existing correction-extent tests now expect ViolationText to be '} ' (brace plus the following space) because the extent now includes that space.
• Added regression tests:
  • the scenario from the issue;
  • a nested block, to check that } and else keep their indentation;
  • the OTBS preset with IgnoreOneLineBlock = $false;
  • the open-brace correction extent.

• Fixes IgnoreOneLineBlock=$false Correction Issue in PSPlaceOpenBrace and PSPlaceCloseBrace #2218