GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle arrays and casts in ValidateRange type-mismatch warnings by Copilot · Pull Request #2273 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Integral ValidateRange bounds can allow out-of-range fractional values on double, single, and decimal parameters. The warning now covers array parameters and cast bounds while avoiding mixed-bound false positives.

  • Detection: Check array element types, resolve cast target types (including aliases), and warn only when both bounds are integral.
  • Regression coverage: Add cases for arrays, casts, aliases, and mixed bounds.
# Warns: array elements use integral boundaries
param([double[]][ValidateRange([int]0.0, [int32]100.0)]$Values)

# No warning: mixed bounds avoid the fractional-boundary issue
param([double][ValidateRange(1, 2.0)]$Value)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
eb5067c
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 28, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2274 October 28, 2026 11:58
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 11:58
View session
@bergmeister
Fix ValidateRange analyzer review findings
d680b9a
Co-authored-by: bergmeister <[email protected]>
Copilot AI changed the title [WIP] Fix code based on review comments Handle arrays and casts in ValidateRange type-mismatch warnings Oct 28, 2026
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 12:04
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 28, 2026 12:04
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 28, 2026 12:11
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2274 October 28, 2026 12:11
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 12:11
View session
Copilot AI reviewed Oct 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the expanded range-type detection and mixed-bound exclusions.

No open issues 🎉

What changed in this PR

Updates AvoidValidateRangeTypeMismatch to detect integral range bounds on floating-point and decimal array parameters and cast expressions, while avoiding mixed-bound false positives.

Changes:

  • Resolve parameter and cast types through reflection, including aliases, and inspect array element types.
  • Require both range bounds to be integral before warning.
  • Add regression cases for arrays, casts, aliases, and mixed bounds.
File Description
Tests/​Rules/​AvoidValidateRangeTypeMismatch.tests.ps1 Adds regression coverage for expanded detection and mixed-bound exclusions.
Rules/​AvoidValidateRangeTypeMismatch.cs Updates type resolution, array handling, and boundary checks.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 28, 2026 12:15
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 28, 2026 12:15
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Copilot why not keep existing test case for decimal type?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as draft October 28, 2026 12:17
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 12:17
View session
@bergmeister
Restore decimal range test coverage
09de08a
Co-authored-by: bergmeister <[email protected]>

Copilot AI commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Copilot why not keep existing test case for decimal type?

The prior decimal case used mixed bounds (1, 2.0), which should now be excluded. I restored decimal positive coverage with integral bounds (1, 2) in commit 09de08a.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 12:22
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2277 October 28, 2026 12:24
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 28, 2026 12:24
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 12:25
View session
Copilot AI reviewed Oct 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the expanded ValidateRange type-mismatch checks.

No open issues 🎉

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2277 October 28, 2026 12:31
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 28, 2026 12:31
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 117fa6b into copilot/validate-range-boundary-check Oct 28, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/fix-code-for-comments branch October 28, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.