GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Tighten DSC resource detection in AvoidAlias by Copilot · Pull Request #2280 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

DSC resource detection could suppress diagnostics for executable commands and scan sibling statements for ordinary commands. It also misclassified assignments, scriptblock expressions, and pipeline elements as resource declarations.

  • Constrain resource detection: Defer body lookup until a configuration ancestor is found. Require a standalone command pipeline and a matching resource header for following-line bodies.
  • Preserve executable diagnostics: Treat assignment and expression contexts as boundaries; only accept command-expression blocks when they match a resource body.
  • Add regressions: Cover assigned commands and scriptblocks, parenthesized expressions, following-line property blocks, and piped commands.
Configuration Example {
    Package App {
        Name = 'Example'
    }

    $result = Verb Argument {}
    Verb Argument {} | Out-Null
}

The resource declaration remains ignored; the executable commands retain their Get-Verb diagnostics.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
9a987dc
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 28, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2281 October 28, 2026 14:54
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 14:55
View session
@bergmeister
Fix AvoidAlias DSC review feedback
60f358a
Co-authored-by: bergmeister <[email protected]>
Copilot AI changed the title [WIP] Fix code based on review comments Tighten DSC resource detection in AvoidAlias Oct 28, 2026
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 15:05
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 28, 2026 15:05
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 28, 2026 15:07
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 28, 2026 15:07
View session
Copilot AI reviewed Oct 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the AvoidAlias DSC resource-detection changes.

No open issues 🎉

What changed in this PR

This PR tightens DSC resource detection in the AvoidAlias rule so executable commands retain diagnostics while resource declarations remain excluded.

Changes:

  • Require a configuration ancestor and a standalone command pipeline before recognizing resource declarations.
  • Treat assignment and parenthesized-expression contexts as boundaries, and validate following-line resource bodies against their headers.
  • Add regression coverage for assignments, scriptblocks, expressions, following-line property blocks, and pipelines.
File Description
Tests/​Rules/​AvoidUsingAlias.tests.ps1 Adds regression tests ensuring executable commands retain alias and implicit-command diagnostics.
Rules/​AvoidAlias.cs Restricts DSC resource detection and validates following-line body associations.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2281 October 28, 2026 15:16
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 28, 2026 15:16
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 28, 2026 15:16
@bergmeister
Christoph Bergmeister (bergmeister) merged commit ee28f10 into copilot/fix-auto-correct-aliases Oct 28, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/fix-review-comments branch October 28, 2026 15:18
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 28, 2026
Preserve DSC resource names during alias correction #2270
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.