GeezerVison is showing github.com — Preserve alias diagnostics after executable commands in DSC ASTs by Copilot · Pull Request #2293 · PowerShell/PSScriptAnalyzer
Conversation
Copilot
AI
commented
Oct 29, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The fallback DSC AST heuristic could mistake a known executable command followed by a standalone block for a resource declaration, suppressing alias diagnostics inside the block.
- Detection: Apply the existing alias and command-resolution checks to following-line resource candidates, while retaining the
Node exception.
- Example: In this layout,
Verb should still receive the Get-Verb correction:
{
Write-Output value
{
Verb Argument {}
}
}
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Preserve alias diagnostics after executable commands in DSC ASTs
Oct 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
There are no active review issues for the DSC fallback heuristic update and its alias-diagnostic regression test.
No open issues 🎉
What changed in this PR
This PR refines the DSC AST fallback heuristic so executable commands followed by standalone blocks do not suppress alias diagnostics inside those blocks.
Changes:
- Apply alias and command-resolution checks to following-line resource candidates while preserving the
Node exception.
- Add a regression test verifying that
Verb still receives the Get-Verb correction after Write-Output.
| File |
Description |
| Tests/Rules/AvoidUsingAlias.tests.ps1 |
Tests alias diagnostics inside a standalone block following an executable command. |
| Rules/AvoidAlias.cs |
Filters following-line DSC resource candidates using alias and command resolution. |
Review effort: Balanced
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.