GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve alias diagnostics after executable commands in DSC ASTs by Copilot · Pull Request #2293 · PowerShell/PSScriptAnalyzer

Conversation

Copilot AI commented Oct 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The fallback DSC AST heuristic could mistake a known executable command followed by a standalone block for a resource declaration, suppressing alias diagnostics inside the block.

  • Detection: Apply the existing alias and command-resolution checks to following-line resource candidates, while retaining the Node exception.
  • Example: In this layout, Verb should still receive the Get-Verb correction:
    {
        Write-Output value
        {
            Verb Argument {}
        }
    }

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
52ca729
Copilot AI assigned Copilot and Christoph Bergmeister (bergmeister) Oct 29, 2026
@bergmeister
Christoph Bergmeister (bergmeister) added this pull request to stack #2294 October 29, 2026 09:53
Copilot started work on behalf of Christoph Bergmeister (bergmeister) October 29, 2026 09:53
View session
@bergmeister
Guard following-line DSC resource detection
5eafbae
Co-authored-by: bergmeister <[email protected]>
Copilot AI changed the title [WIP] Fix code based on review comments Preserve alias diagnostics after executable commands in DSC ASTs Oct 29, 2026
Copilot finished work on behalf of Christoph Bergmeister (bergmeister) October 29, 2026 10:02
Copilot AI requested a review from Christoph Bergmeister (bergmeister) October 29, 2026 10:02
@bergmeister
Christoph Bergmeister (bergmeister) requested a balanced review from Copilot October 29, 2026 10:56
Copilot started reviewing on behalf of Christoph Bergmeister (bergmeister) October 29, 2026 10:56
View session
Copilot AI reviewed Oct 29, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the DSC fallback heuristic update and its alias-diagnostic regression test.

No open issues 🎉

What changed in this PR

This PR refines the DSC AST fallback heuristic so executable commands followed by standalone blocks do not suppress alias diagnostics inside those blocks.

Changes:

  • Apply alias and command-resolution checks to following-line resource candidates while preserving the Node exception.
  • Add a regression test verifying that Verb still receives the Get-Verb correction after Write-Output.
File Description
Tests/​Rules/​AvoidUsingAlias.tests.ps1 Tests alias diagnostics inside a standalone block following an executable command.
Rules/​AvoidAlias.cs Filters following-line DSC resource candidates using alias and command resolution.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 29, 2026 11:23
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from a team as a code owner October 29, 2026 11:23
@bergmeister
Christoph Bergmeister (bergmeister) removed this pull request from stack #2294 October 29, 2026 11:23
@bergmeister
Christoph Bergmeister (bergmeister) merged commit e51412d into copilot/fix-auto-correct-aliases Oct 29, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/fix-code-comments-review-thread-2270 branch October 29, 2026 11:23
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Oct 29, 2026
Preserve DSC resource names during alias correction #2270
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bergmeister Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bergmeister Christoph Bergmeister (bergmeister)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.