GeezerVison is showing github.com — Fix analyzer diagnostics and preserve PowerShell formatting by HuffmanStacks · Pull Request #2301 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
Make analyzer diagnostics more precise and preserve the layout of scripts when applying formatting corrections.
Contributed by Christopher Huffman (@HuffmanStacks) with Codex assistance.
Each change is in a separate commit for review.
Validation
- 182 focused Pester tests passed on Linux with each of PowerShell 7.4.14 and 7.6.6.
- The broader Linux suite passed 2,142 tests, with 163 skipped. Four tests failed on both the baseline and the branch because the runner could not resolve the PowerShell process path. All four CLI behaviors passed when replayed with the executable path.
- The Engine and Rules assemblies were compiled with the .NET 8 SDK compiler. Windows and macOS validation is pending upstream CI.
- PSScriptAnalyzer reported zero findings across five selected rules on the eight changed PowerShell files.
PR Checklist
- Meaningful title and summarized changes
- Existing source copyright headers retained
- Regression tests and documentation updated where applicable
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@microsoft-github-policy-service agree
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.