GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP Fix Exception when trying to analyze custom attribute that is being defined in different file by bergmeister · Pull Request #995 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented May 9, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #966
This is a quick fix. I would like to understand more details of it. If the definition is not part of a file being analysed by PSSA or know to PowerShell then we cannot do anything. But maybe I can improve the overall pre-analysis or something else.
A test is to be written.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed -> Maybe tell the user to load as many definitions as possible into the PowerShell sessions first
  • Change is not breaking
  • To be done. Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 2 commits May 9, 2018 22:26
@bergmeister
catch specific error for custom attribute being defined in other file
7283599
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
d13f615 
…nalyzer into FixIssue966
@bergmeister Christoph Bergmeister (bergmeister) added the Issue - Bug label Jan 9, 2019
@bergmeister
Christoph Bergmeister (bergmeister) changed the base branch from development to master June 13, 2020 18:08
@hubuk Hubert Bukowski (hubuk) mentioned this pull request Apr 6, 2021
Alternative way of obtaining function AST. #1659
Merged
5 of 6 tasks
@rjmholt
Rob Holt (rjmholt) marked this pull request as draft April 21, 2021 21:14
@hubuk

Hubert Bukowski (hubuk) commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

May be closed as handled in #1659
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception occurred while constructing custom validator attribute.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @hubuk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.