GeezerVison

// These dictionaries prevent reloading already loaded and unchanged code.

// We don't worry about unbounded growing of the cache because in .Net Core 2.0 we can not unload assemblies.

// TODO: review if we will be able to unload assemblies after migrating to .Net Core 2.1.

private static readonly Dictionary<string, int> s_sourceTypesCache = new Dictionary<string, int>();

private static readonly HashSet<string> s_sourceTypesCache = new HashSet<string>();

private static readonly Dictionary<int, Assembly> s_sourceAssemblyCache = new Dictionary<int, Assembly>();

private static readonly string s_defaultSdkDirectory = Utils.DefaultPowerShellAppBase;

private void CheckDuplicateTypes(Compilation compilation, out ConcurrentBag<string> newTypes)

{

AllNamedTypeSymbolsVisitor visitor = new AllNamedTypeSymbolsVisitor(_syntaxTreesHash);

AllNamedTypeSymbolsVisitor visitor = new AllNamedTypeSymbolsVisitor();

visitor.Visit(compilation.Assembly.GlobalNamespace);

foreach (var symbolName in visitor.DuplicateSymbols)

// Visit symbols in all namespaces and collect duplicates.

private class AllNamedTypeSymbolsVisitor : SymbolVisitor

{

private readonly int _hash;

public readonly ConcurrentBag<string> DuplicateSymbols = new ConcurrentBag<string>();

public readonly ConcurrentBag<string> UniqueSymbols = new ConcurrentBag<string>();

public AllNamedTypeSymbolsVisitor(int hash)

{

_hash = hash;

}

public override void VisitNamespace(INamespaceSymbol symbol)

{

// Main cycle.

// It is namespace-fully-qualified name

var symbolFullName = symbol.ToString();

if (s_sourceTypesCache.TryGetValue(symbolFullName, out int hash))

if (s_sourceTypesCache.TryGetValue(symbolFullName, out _))

{

if (hash == _hash)

{

DuplicateSymbols.Add(symbolFullName);

}

DuplicateSymbols.Add(symbolFullName);

}

else

{

{

foreach (var typeName in newTypes)

{

s_sourceTypesCache.Add(typeName, _syntaxTreesHash);

s_sourceTypesCache.Add(typeName);

}

}

$code = @"

{ Add-Type -CompilerOptions "/platform:anycpuERROR" -Language CSharp -MemberDefinition "public static string TestString() { return ""}" -Name "TestType1" -Namespace "TestNS" -ErrorAction Stop } | Should -Throw -ErrorId "SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand"

}

It "Throw if the type already exists" {

Add-Type -TypeDefinition "public class Foo$guid {}"

{ Add-Type -TypeDefinition "public class Foo$guid { public int Bar {get {return 42;} }" -ErrorAction SilentlyContinue } | Should -Throw -ErrorId "COMPILER_ERRORS,Microsoft.PowerShell.Commands.AddTypeCommand"

$error[1].FullyQualifiedErrorId | Should -BeExactly "TYPE_ALREADY_EXISTS,Microsoft.PowerShell.Commands.AddTypeCommand"

}

It "OutputType parameter requires that the OutputAssembly parameter be specified." {

$code = "public static string TestString() {}"

{ Add-Type -TypeDefinition $code -OutputType Library } | Should -Throw -ErrorId "OUTPUTTYPE_REQUIRES_ASSEMBLY,Microsoft.PowerShell.Commands.AddTypeCommand"