GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Update 'SaveError' in 'Parser.cs' to not depend on LINQ expression tree to get the error id · Issue #6444 · PowerShell/PowerShell Closed Labels Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-FixedThe issue is fixed.The issue is fixed. DescriptionQuote Jason's comment at https://github.com/PowerShell/PowerShell/pull/6434/files/5b5be3122971552d2ce208858ac84868954b841c#r175933192 I'd suggest removing my ugly hack of using LINQ expression trees in When that code was written,
Performance might matter more than I originally assumed given editor scenarios - and given the ReportIncompleteInput(lCurly.Extent, rCurly.Extent, ParserStrings.MissingEndCurlyBrace, nameof(ParserStrings.MissingEndCurlyBrace)); In other words, pass the error text and the error id. Alternatively you could just pass the error id and use reflection of some sort to load the error string, but that would not be good for performance. Activity
MetadataMetadataAssigneesLabelsIssue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-FixedThe issue is fixed.The issue is fixed. TypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |