GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add VerboseAction, DebugAction, ProgressAction, VerboseVariable, DebugVariable, and ProgressVariable common parameters by KirkMunro · Pull Request #10238 · PowerShell/PowerShell

Conversation

@KirkMunro

@KirkMunro Kirk Munro (KirkMunro) commented Jul 27, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  • Add VerboseAction (va), DebugAction (da), ProgressAction (pra), VerboseVariable (vv), DebugVariable (dv), and ProgressVariable (prv) common parameters.
  • Remove unnecessary restriction around ActionPreference.Ignore (see this discussion in issue 4348). (this has been moved to PR Transition ActionPreference.Suspend enumeration value into a non-supported, reserved state, and remove restriction on using ActionPreference.Ignore in preference variables #10317)
  • Add default output for progress messages when rendered in the console.
  • Change behavior of Write-Verbose and Write-Warning such that they simply output their messages if they are invoked with -Debug. This was missed in PR Debug parameter now sets debugpreference to continue #8195.
  • Fixed bug in handling of PSCmdlet.WriteVerbose and PSCmdlet.WriteWarning methods. When a cmdlet is invoked without any common parameters, and that cmdlet invokes one of these methods, the cmdlet runtime was supposed to read the corresponding preference value once and then use that value in all subsequent invocations, for performance reasons. WriteVerbose and WriteWarning were not properly setting a flag when the value was read, and as a result were reading it again every time. See here for a more detailed discussion about this.

PR Context

As per #6702 and some considerations on one of my RFCs, this PR normalizes the common parameter set to allow for better scripter control for any stream in PowerShell.

This is the first step in facilitating easier capturing of stream data for logging purposes.

For the enquiring mind, it is even important to capture progress records, because some scripts are written to show a bunch of progress messages but not much else, and when these are run unattended and fail, it is impossible to know how far along they went before they failed. Capturing progress messages makes that problem go away.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s): PSNewCommonParameters
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Document new common parameters in about_commonparameters MicrosoftDocs/PowerShell-Docs#4929
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jazzdelightsme reacted with thumbs up emoji Jaykul, ThomasNieto, and M1kep reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 3 reactions
Kirk Munro (KirkMunro) added 2 commits July 26, 2019 22:25
@KirkMunro
normalize stream common parameters
e996df8
@KirkMunro
test updates
fc21ea9
@KirkMunro
Kirk Munro (KirkMunro) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners July 27, 2019 01:51
PoshChan
PoshChan-Bot (PoshChan) reviewed Jul 27, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

PoshChan
PoshChan-Bot (PoshChan) reviewed Jul 27, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

PoshChan
PoshChan-Bot (PoshChan) reviewed Jul 27, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Kirk Munro (KirkMunro) added 2 commits July 26, 2019 23:11
@KirkMunro
CodeFactor update plus some Pester fixes
5429151
@KirkMunro
fix to Pester test
813f936
@Jaykul

Joel Bennett (Jaykul) commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

The alias for -Verbose is -vb and the alias for -Debug is -db ...

Should their respective Action and Variable short forms start with those prefixes?

That is, should -VerboseAction be -vba instead of -va, etc.?

I'm not sure. Certainly the InformationAction is the only one of the existing aliases that isn't a two-letter alias (and I don't actually know why), so there's good reason to stick with 2-letter initialisms.

Luiz-Monad reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@KirkMunro

Kirk Munro (KirkMunro) commented Jul 27, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'm not sure either. Also, used three letters for the progress aliases (pra and prv) to differentiate them from the -PipelineVariable alias while maintaining "suffix" consistency between them and with the other aliases.

That is, should -VerboseAction be -vba instead of -va, etc.?

I don't think we want vba in PowerShell. 😝

Kidding of course. I'm not attached to anything I chose...I just picked what made sense at the time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Jul 28, 2019

Copy link
Copy Markdown
Collaborator

We should probably also make note that using -v as a shorthand for -Verbose is pretty common, especially in interactive cases.

If we're adding more parameters that by default conflict with that shorthand, we should probably add that as an explicit alias as well. :)

robdy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@KirkMunro

Kirk Munro (KirkMunro) commented Jul 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

So here's an idea. These new parameters make the usefulness of -Verbose and -Debug questionable. Those are convenient, but not as capable as the new common parameters. What if -VerboseAction was defined as a Switchable<ActionPreference>, where Switchable<T> is a new generic type whose constructor accepts the true and false T values for the type, plus assignment operators for bool and T, and an implicit conversion operator to T. Switchable<T> would also need to be supported in the parser as a parameter with no value, of course. This is just thinking out loud, but I've been brainstorming some ideas on how I could obsolete old switches without breaking scripts, and with a proper alias plus the Switchable<T> type, this would allow switches like -Verbose and -Debug, and even -Information if we wanted it, to just work as if they were common switch parameters without even having them explicitly defined (-Warning, -Progress, and -Error would not be necessary since those messages are shown by default).

The benefit with this approach is to simplify and normalize the common parameters without losing muscle memory and without breaking existing scripts. This generic type would also provide a pattern that would allow for switch replacement in any other command, should the need for that arise.

jazzdelightsme, Jaykul, vexx32, mklement0, and Luiz-Monad reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Jul 29, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread ...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/resources/FormatStrings.Designer.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Write-Stream.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Write-Stream.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Kirk Munro (KirkMunro) and others added 11 commits July 29, 2019 11:21
@KirkMunro @iSazonov
Update src/System.Management.Automation/engine/MshCommandRuntime.cs
2717565
Co-Authored-By: Ilya <[email protected]>
@KirkMunro @iSazonov
Update src/System.Management.Automation/engine/MshCommandRuntime.cs
314bf05
Co-Authored-By: Ilya <[email protected]>
@KirkMunro @iSazonov
Update src/System.Management.Automation/engine/MshCommandRuntime.cs
9ee62ec
Co-Authored-By: Ilya <[email protected]>
@KirkMunro @iSazonov
Update src/System.Management.Automation/engine/MshCommandRuntime.cs
84a6eb1
Co-Authored-By: Ilya <[email protected]>
@KirkMunro @iSazonov
Update src/System.Management.Automation/engine/MshCommandRuntime.cs
9f50c65
Co-Authored-By: Ilya <[email protected]>
@KirkMunro
remove file that is auto-generated
3dfb20f
@KirkMunro
Merge branch 'normalize-common-parameters' of https://github.com/Kirk…
de65104
…Munro/PowerShell into normalize-common-parameters
@KirkMunro @iSazonov
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Write-Str…
4531f36
…eam.Tests.ps1

Co-Authored-By: Ilya <[email protected]>
@KirkMunro
Merge branch 'normalize-common-parameters' of https://github.com/Kirk…
5b101c6
…Munro/PowerShell into normalize-common-parameters
@KirkMunro
review updates
a0e6e7f
@KirkMunro
sort common parameter usage
d78f5bf
@KirkMunro

Kirk Munro (KirkMunro) commented Jul 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Here is a screenshot that shows what ProgressRecord output looks like using the formatter:

image

Aside: That this screenshot demonstrates the problem identified in issue #10236 (many *Record types default format does not identify the actual type of message that is being conveyed, but they really should for logging/review/searching purposes).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

KirkMunro
Kirk Munro (KirkMunro) commented Jul 29, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

KirkMunro
Kirk Munro (KirkMunro) commented Jul 29, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

KirkMunro
Kirk Munro (KirkMunro) commented Jul 29, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

KirkMunro
Kirk Munro (KirkMunro) commented Jul 29, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/MshCommandRuntime.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 28, 2020
@ghost

Deleted user (ghost) commented Jul 28, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@KirkMunro Kirk Munro (KirkMunro) mentioned this pull request Oct 22, 2020
Close the feature gap between the Where-Object cmdlet and the .Where() array method, introduce -First, -Last, ... switches #13834
Closed
@TravisEz13 Travis Plunk (TravisEz13) added WG-Engine core PowerShell engine, interpreter, and runtime Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 27, 2020
@ghost ghost added the Stale label Nov 11, 2020
@ghost

Deleted user (ghost) commented Nov 11, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost closed this Nov 22, 2020
@KirkMunro

Kirk Munro (KirkMunro) commented Nov 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

C'mon, guys. 1.5 years post PR submission, you finally move forward with some action on this, but then your attention wanes at the end when some important questions are put on the table, and then you let it go stale and be closed? Travis Plunk (@TravisEz13): How was this marked waiting on author when the author (me) had responded with questions back to Paul Higinbotham (@PaulHigin)?

It really is no wonder why I put my I put my interest in pushing PRs into this repo on hold until you all could catch up with the PRs that were already open and the discussions that were already started. I'm not all that surprised that this hasn't happened yet, but what does surprise me is that rather than properly managing what's there, you're allowing it get discarded. Such a waste.

jazzdelightsme, ThomasNieto, powercode, ManuelRin, stej, jantari, mklement0, and claudio-salvio reacted with thumbs up emoji
All reactions
  • 👍 8 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Nov 24, 2020
@iSazonov Ilya (iSazonov) reopened this Nov 24, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 1, 2020
@ghost

Deleted user (ghost) commented Dec 1, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@KirkMunro

Kirk Munro (KirkMunro) commented Apr 24, 2021

Copy link
Copy Markdown
Contributor Author

I'm walking away from my open PRs. I'm not really involved in PowerShell much these days. Personally I spend very little time using it, and at this point I don't have the time nor the motivation to deal with PRs submitted over 18 months ago.

As a point of feedback, this community is stagnant and unhealthy to participate in. It takes far too much personal effort and lobbying like a politician to get anything moving. Ideas on how to help the community move forward take years, and years, and years to bear any fruit at all. In software development, there is a balance between driving software forward based on internal business and internal/external customer priorities, and driving features and functionality that are quality of life improvements for the community of users using a product. This community has been, and in my mind clearly still is, focused almost exclusively on the former, and only considers the latter when it is of benefit to their goals for the former. It is not balanced at all when it comes to community contributions. Glancing at the history of closed PRs, and who those PRs come from, is clear evidence of this, and it seems obvious where your focus is internally for team member MBOs.

vexx32, SeeminglyScience, mklement0, Jaykul, bchap1n, weq, danielkrash, Stephanevg, IISResetMe, JPRuskin, and 21 more reacted with thumbs up emoji bergmeister, robdy, ManuelRin, stej, SeidChr, wisemoth, and Szeraax reacted with confused emoji HumanEquivalentUnit, kborowinski, vexx32, morsley, jantari, NicoNekoru, and Szeraax reacted with heart emoji Jawz84, TechDufus, Luiz-Monad, and Szeraax reacted with eyes emoji
All reactions
  • 👍 31 reactions
  • 😕 7 reactions
  • ❤️ 7 reactions
  • 👀 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@KirkMunro Kirk Munro (KirkMunro) closed this Apr 24, 2021
This was referenced Apr 24, 2021
Add property, method, and indexed item splatting support #11003
Closed
Add -is $null and -isnot $null support to operators and Where-Object #10704
Closed
WIP: Deprecate workflow-related keywords (workflow, sequence, parallel, and inlinescript) #10318
Closed
@mklement0

Michael Klement (mklement0) commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

Kirk Munro (@KirkMunro), I was going to say that we'll miss your contributions in all forms in this community.

But then I realized: there is no we.
But first, let's invite a few more people to the good-bye party: Steve Lee (@SteveL-MSFT), Joey Aiello (@joeyaiello), Bruce Payette (@bpayette), Rob Holt (@rjmholt), Sean Wheeler (@sdwheeler).

I share your assessment of what is problematic about this community; let me point to two particularly striking examples that I've personally expended a lot of energy on:

  • Do not require { ... } (curly braces) around variable names for null-conditional member access #14025 (comment) (not requiring {...} around variable names for the null-conditional operators, ?. / ?[])
  • Implement accommodations for Windows CLIs, notably batch files and misexec-style programs as part of experimental feature PSNativeCommandArgumentPassing #15143 (comment) (comprehensive solution to the perennial quoting headaches when calling native executables)

In my perception, these two issues (the specific comments tell the history) exemplify several problematic patterns:

  • Fiat decisions handed down with little to no explanation, often indicative of unawareness of the specifics of a proposal / lack of sufficient subject-matter expertise, followed by unwillingness to explain or debate the decision.

    • Working groups were supposed to help with that, but in my personal experience it seems to be just more of the same.
  • Many quality-of-life-improvement proposals either getting ignored altogether, being met with indignant pushback ("very much by design"), argument-less claims of lack of arguments ("I don't believe you've made the argument sufficiently"), followed by eternal silence when counterarguments are made.

  • Vague promises of revisiting issues that never materialize.

I hope that the many talented people that still make up this community have the stamina to continue to contribute, as things - hopefully - improve, but personally I feel burned out and, save for perhaps filing the occasional bug report prompted by real-life use, I will cease my activities here and in the docs repo.

vexx32, Stephanevg, robdy, IISResetMe, Szeraax, morsley, jantari, NicoNekoru, TSlivede, claudio-salvio, and 6 more reacted with thumbs up emoji ranabanerjee15 reacted with confused emoji HumanEquivalentUnit, stej, itfranck, IISResetMe, morsley, kborowinski, vexx32, jantari, NicoNekoru, and santisq reacted with heart emoji Jaykul, Jawz84, Stephanevg, sheldonhull, ranabanerjee15, and Luiz-Monad reacted with eyes emoji
All reactions
  • 👍 16 reactions
  • 😕 1 reaction
  • ❤️ 10 reactions
  • 👀 6 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Apr 30, 2021
Get-Item ./.hidden-file fails with "Could not find item" #15323
Closed
Script via STDIN does not exit with error code and does not stop correctly #15331
Closed
Implement accommodations for Windows CLIs, notably batch files and misexec-style programs as part of experimental feature PSNativeCommandArgumentPassing #15143
Closed
@mklement0 Michael Klement (mklement0) mentioned this pull request May 12, 2021
Remote sessions targeting Windows machines unexpectedly use ANSI character encoding for external programs #15128
Closed
@AndrewSav Andrew Savinykh (AndrewSav) mentioned this pull request Jun 25, 2021
Home, End, Ctr+Arrow don't work (Arch/Linux 4.20) #8869
Closed
@gogbg Georgi Ivanov (gogbg) mentioned this pull request Nov 22, 2021
Unable to load multiple versions of .Net assembly module dependencies. #2083
Closed
@mklement0 Michael Klement (mklement0) mentioned this pull request Dec 23, 2021
Use forward slashes by default in Windows #10509
Closed
@MartinGC94 MartinGC94 mentioned this pull request Dec 6, 2022
Add -ProgressAction as a common parameter #18737
Closed
@HumanEquivalentUnit HumanEquivalentUnit mentioned this pull request Feb 10, 2023
PowerShell 7.3 doesn't pass variable values / cmdlet results arguments to child processes when comma is present #18502
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+2 more reviewers
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin requested changes
@PoshChan PoshChan-Bot (PoshChan) PoshChan left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Documentation Needed in this repo Documentation is needed in this repo Review - Needed The PR is being reviewed WG-Engine core PowerShell engine, interpreter, and runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@KirkMunro @Jaykul @vexx32 @PoshChan @iSazonov @TravisEz13 @PaulHigin @mklement0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.