GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make `StringUtil` classes static by xtqqczze · Pull Request #15671 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Follow-up #14483.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Make classes having only static members static
391f429
@ghost ghost assigned Travis Plunk (TravisEz13) Jun 25, 2021
@xtqqczze xtqqczze mentioned this pull request Jun 25, 2021
OBSOLETE: Update accessibility modifiers #11773
Closed
8 tasks done
iSazonov
Ilya (iSazonov) approved these changes Jun 25, 2021
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 25, 2021
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Jun 28, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs
/// Simple string formatting helper.
/// </summary>
internal class StringUtil
internal static class StringUtil

@daxian-dbw Dongbo Wang (daxian-dbw) Jun 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScheduledJob module is not being built in the code base today, so please undo the change here.
Actually, we may need to think about remove the code that is not used today.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jun 28, 2021

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) LocalAccounts/StringUtil.cs too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@xtqqczze xtqqczze Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) I guess work to remove uncompiled code is covered by #9960?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Ilya (iSazonov) self-requested a review July 1, 2021 03:52
@iSazonov

Ilya (iSazonov) commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

The code is not in compile.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw left review comments
@iSazonov Ilya (iSazonov) Awaiting requested review from iSazonov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @iSazonov @daxian-dbw @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.