GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update TLS test based on current platform settings by TravisEz13 · Pull Request #17424 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented May 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Backport 38909f7

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions @TravisEz13
TLS test fix back-port (PowerShell#17061)
ee4035f
# Conflicts:
#	test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
# 38909f7
@ghost ghost assigned Andrew (anmenaga) May 24, 2022
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Large label May 24, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 24, 2022

Copy link
Copy Markdown

This PR has 7427 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +4795 -2632
Percentile : 100%

Total files changed: 157

Change summary by file extension:
.psm1 : +760 -743
.yml : +1098 -274
.spelling : +28 -1
.props : +3 -2
.md : +944 -798
.json : +926 -15
.txt : +118 -57
.wxs : +137 -5
.config : +1 -1
.yaml : +0 -0
.csproj : +42 -42
.cs : +176 -210
.psd1 : +17 -32
.resx : +6 -0
.lock : +0 -0
.ps1 : +538 -92
docker/tests/Templates/centos7/Dockerfile : +0 -19
docker/tests/Templates/debian.9/Dockerfile : +0 -25
docker/tests/Templates/fedora28/Dockerfile : +0 -22
docker/tests/Templates/fxdependent-centos7/Dockerfile : +0 -25
docker/tests/Templates/fxdependent-debian.9/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-dotnetsdk-latest/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-fedora28/Dockerfile : +0 -32
docker/tests/Templates/fxdependent-opensuse42.3/Dockerfile : +0 -35
docker/tests/Templates/fxdependent-ubuntu16.04/Dockerfile : +0 -33
docker/tests/Templates/fxdependent-ubuntu18.04/Dockerfile : +0 -26
docker/tests/Templates/opensuse42.3/Dockerfile : +0 -31
docker/tests/Templates/ubuntu16.04/Dockerfile : +0 -25
docker/tests/Templates/ubuntu18.04/Dockerfile : +0 -25
test/docker/networktest/Dockerfile : +1 -1
tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile : +0 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) changed the base branch from master to release/v7.2.5 May 24, 2022 17:46
@TravisEz13 Travis Plunk (TravisEz13) changed the title tls test fixes Update TLS test based on current platform settings May 24, 2022
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review May 24, 2022 20:05
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the Backport-7.2.x-Approved label May 24, 2022
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes May 24, 2022
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 8af2f5c into PowerShell:release/v7.2.5 May 24, 2022
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.2.x-Done and removed Backport-7.2.x-Approved labels May 24, 2022
@TravisEz13
Travis Plunk (TravisEz13) deleted the tls-test-fixes branch May 31, 2022 19:11
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jun 7, 2022
Backport test fixes for 7.2 #17494
Merged
22 tasks
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 16, 2022
@ghost

Deleted user (ghost) commented Jun 21, 2022

Copy link
Copy Markdown

🎉v7.2.5 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Apr 16, 2024
WIP: add more detail to suspicious scriptblock logging #21475
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 9, 2024
Add script to update SDK for release branches #24034
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

Backport-7.2.x-Done CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @adityapatwardhan @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.