GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.3.0] Add authenticode signing for assemblies on linux builds by github-actions[bot] · Pull Request #18449 · PowerShell/PowerShell

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Backport of #18440 to release/v7.3.0

/cc Aditya Patwardhan (@adityapatwardhan)

Customer Impact

Testing

  • For any change that affects the release process, please work with a maintainer to come up with a plan to test this.

Risk

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aditya Patwardhan (adityapatwardhan) and others added 27 commits November 2, 2022 23:07
@adityapatwardhan
Split packaging to separate step
5e53b19
@adityapatwardhan
Fix yaml download task
8cbb734
@adityapatwardhan
fixes
44cd8c5
@adityapatwardhan
Fix publish and download
ce77e28
@adityapatwardhan
Fixes
01566b2
@adityapatwardhan
Separate build and packaging
a2cbcd5
@adityapatwardhan
Remove duplicate
dd87bc3
@adityapatwardhan
Remove duplicate 2
c8c585a
@adityapatwardhan
Fix meta downloads and job deps
9d968b5
@adityapatwardhan
Add alpine packaging
ee330e8
@adityapatwardhan
Multiple fixes
c4db27d
@adityapatwardhan
Fix yaml condition
ff18e85
@adityapatwardhan
Fix build types
7975753
@adityapatwardhan
Fix build downloads
2185872
@adityapatwardhan
Fix alpine and fxdependent packaging
ab8c8ed
@adityapatwardhan
Fix typo
a38db12
@adityapatwardhan
Fix fxd package name
4cb9a2d
@adityapatwardhan
Add signing
b779828
@adityapatwardhan
Fix indent
a09b235
@adityapatwardhan
Fix indent 2
04c9a61
@adityapatwardhan
Make signing a template
d191053
@adityapatwardhan
Call the correct template
421eb50
@adityapatwardhan
Fix template
3514774
@adityapatwardhan
Fix variable name
6298127
@adityapatwardhan
Use the correct artifacts to sign
dba429e
@adityapatwardhan
Fix dependencies
0f20d54
@adityapatwardhan @TravisEz13
Apply suggestions from code review
23b7f36
Co-authored-by: Travis Plunk <[email protected]>
@github-actions
github-actions Bot requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 2, 2022 23:07
@github-actions
github-actions Bot requested review from Paul Higinbotham (PaulHigin) and Andrew (anmenaga) as code owners November 2, 2022 23:07
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Large label Nov 2, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Nov 2, 2022

Copy link
Copy Markdown

This PR has 829 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +645 -184
Percentile : 94.3%

Total files changed: 5

Change summary by file extension:
.yml : +645 -184

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost assigned Ilya (iSazonov) Nov 2, 2022
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 3, 2022
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 383a918 into release/v7.3.0 Nov 3, 2022
@TravisEz13
Travis Plunk (TravisEz13) deleted the backport/pr-18440-to-release/v7.3.0 branch November 3, 2022 00:45
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Nov 29, 2022
Powershell files from official Microsoft Nuget Microsoft.PowerShell.SDK are not signed #18247
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

Extra Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.