GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.2.9] Add authenticode signing for assemblies on linux builds by github-actions[bot] · Pull Request #18920 · PowerShell/PowerShell

Conversation

@github-actions

@github-actions github-actions Bot commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Backport of #18440 to release/v7.2.9

/cc Travis Plunk (@TravisEz13) Aditya Patwardhan (@adityapatwardhan)

Customer Impact

Testing

  • For any change that affects the release process, please work with a maintainer to come up with a plan to test this.

Risk

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aditya Patwardhan (adityapatwardhan) and others added 27 commits January 10, 2023 19:46
@adityapatwardhan
Split packaging to separate step
1c90011
@adityapatwardhan
Fix yaml download task
5834f45
@adityapatwardhan
fixes
fa1efe1
@adityapatwardhan
Fix publish and download
6367134
@adityapatwardhan
Fixes
ac70d03
@adityapatwardhan
Separate build and packaging
a060c41
@adityapatwardhan
Remove duplicate
0e31c8e
@adityapatwardhan
Remove duplicate 2
5106387
@adityapatwardhan
Fix meta downloads and job deps
986fa4f
@adityapatwardhan
Add alpine packaging
1197a18
@adityapatwardhan
Multiple fixes
2da5e2f
@adityapatwardhan
Fix yaml condition
ea311c4
@adityapatwardhan
Fix build types
f57b7c2
@adityapatwardhan
Fix build downloads
c7413da
@adityapatwardhan
Fix alpine and fxdependent packaging
d6b76b2
@adityapatwardhan
Fix typo
4b4549e
@adityapatwardhan
Fix fxd package name
e692c84
@adityapatwardhan
Add signing
988ab97
@adityapatwardhan
Fix indent
aaa1084
@adityapatwardhan
Fix indent 2
3672749
@adityapatwardhan
Make signing a template
84f95f4
@adityapatwardhan
Call the correct template
d05f56d
@adityapatwardhan
Fix template
c546209
@adityapatwardhan
Fix variable name
f8564a0
@adityapatwardhan
Use the correct artifacts to sign
fc9fac1
@adityapatwardhan
Fix dependencies
dd07c54
@adityapatwardhan @TravisEz13
Apply suggestions from code review
a0ac103
Co-authored-by: Travis Plunk <[email protected]>
@github-actions
github-actions Bot requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners January 10, 2023 19:46
@github-actions
github-actions Bot requested review from Paul Higinbotham (PaulHigin) and Andrew (anmenaga) as code owners January 10, 2023 19:46
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Large label Jan 10, 2023
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 10, 2023

Copy link
Copy Markdown

This PR has 829 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +645 -184
Percentile : 94.3%

Total files changed: 5

Change summary by file extension:
.yml : +645 -184

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost assigned Travis Plunk (TravisEz13) Jan 10, 2023
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 10, 2023
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 8306762 into release/v7.2.9 Jan 10, 2023
@TravisEz13
Travis Plunk (TravisEz13) deleted the backport/pr-18440-to-release/v7.2.9 branch January 10, 2023 19:59
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 23, 2023
@ghost

Deleted user (ghost) commented Jan 24, 2023

Copy link
Copy Markdown

🎉v7.2.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Feb 2, 2023
Powershell files from official Microsoft Nuget Microsoft.PowerShell.SDK are not signed #18247
Closed
5 tasks done
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Apr 16, 2024
WIP: add more detail to suspicious scriptblock logging #21475
Closed
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jul 9, 2024
Add script to update SDK for release branches #24034
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@TravisEz13 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.