GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix duplicate results from Get-Command fuzzy matching by daxian-dbw · Pull Request #28042 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

Fixes #26593

Note: It's much easier to review the PR by ignoring the whitespace changes: https://github.com/PowerShell/PowerShell/pull/28042/changes?w=1

  • Filter fuzzy module candidates through the existing Get-Command duplicate and parameter checks before adding them to scored output
  • Preserve the score associated with each accepted command
  • Add a cross-platform regression test using two discoverable copies of the same module

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Fix duplicate fuzzy Get-Command results
18a1db1 
Filter fuzzy module candidates before adding them to the scored output collection, and cover duplicate module discovery with a focused regression test.

Co-authored-by: Copilot App <[email protected]>
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner September 21, 2026 21:09
Copilot AI lite review requested due to automatic review settings September 21, 2026 21:09
@azure-pipelines

azure-pipelines Bot commented Sep 21, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 21, 2026
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) September 21, 2026 21:09
View session
Copilot AI reviewed Sep 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All reviewed changes are covered by the supplied validation and have no unresolved blocking issues.

Review effort: Lite
Findings: None

What changed in this PR

Fixes duplicate results from fuzzy Get-Command matching while preserving candidate scores.

Changes:

  • Filters duplicate fuzzy candidates using existing checks.
  • Adds cross-platform regression coverage.
File Description
test/​powershell/​Modules/​Microsoft.PowerShell.Utility/​Get-Command.Tests.ps1 Adds duplicate-result regression coverage.
src/​System.Management.Automation/​engine/​GetCommandCommand.cs Filters fuzzy candidates and retains scores.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kilasuit
Ryan Yates (kilasuit) approved these changes Sep 22, 2026
View reviewed changes

@kilasuit Ryan Yates (kilasuit) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested a local build of this branch too and all good there

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Sep 29, 2026
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jshigetomi
Justin Chung (jshigetomi) approved these changes Oct 8, 2026
View reviewed changes

@jshigetomi Justin Chung (jshigetomi) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the fuzzy candidate filtering, score preservation, duplicate handling, and regression coverage. Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit bd8cb01 into PowerShell:master Oct 9, 2026
39 of 40 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the daxian-dbw-fix-fuzzy-command-duplicates branch October 9, 2026 16:35
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Needed The PR is being reviewed label Oct 9, 2026
tn4443450-coder
tn4443450-coder approved these changes Nov 3, 2026
View reviewed changes
@tn4443450-coder

tn4443450-coder commented Nov 3, 2026

Copy link
Copy Markdown

HOPE
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jshigetomi Justin Chung (jshigetomi) jshigetomi approved these changes
+2 more reviewers
@kilasuit Ryan Yates (kilasuit) kilasuit approved these changes
@tn4443450-coder tn4443450-coder tn4443450-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get-Command -UseFuzzyMatching output includes duplicates

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@daxian-dbw @tn4443450-coder @kilasuit @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.