GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — [release/v7.4.21] Change Windows CI to stop using PowerShell 5.1 by adityapatwardhan · Pull Request #28049 · PowerShell/PowerShell Conversation
Member
Backport of #27940 to release/v7.4.21 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Dongbo Wang (@daxian-dbw) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Stops Windows CI from depending on Windows PowerShell 5.1 and uses the supported PowerShell Core execution path for release-branch validation. Customer Impact
RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingCherry-pick completed cleanly, git diff --check passed, and tools/WindowsCI.psm1 parses successfully with no conflict markers. Windows workflow execution will be validated by backport CI. RiskREQUIRED: Check exactly one box.
High risk because this changes the PowerShell host used by Windows CI. The implementation is narrowly scoped to the workflow action and WindowsCI module adjustment already validated on master.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
requested a review
from a team
as a code owner
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🔵 Needs a closer lookThe change alters the PowerShell host used by Windows CI and requires final human validation. Review effort: Lite What changed in this PRUpdates Windows CI to use PowerShell Core instead of Windows PowerShell 5.1. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
Patrick Meinecke (SeeminglyScience)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
b6fd898
into
PowerShell:release/v7.4.21
39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.4.21/27940-13b2fd125
branch
Justin Chung (jshigetomi)
approved these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |