GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — [release/v7.4.21] Simplify Microsoft Store listing metadata by adityapatwardhan · Pull Request #28050 · PowerShell/PowerShell Conversation
Member
Backport of #27968 to release/v7.4.21 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Required release tooling change that makes the static PDP the source of Store listing language, limits publishing-time substitutions to version values, removes obsolete AppStoreName mutation, and supplies the PDP root for StoreBroker's required media-root input. Customer Impact
RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingThe original change was validated through Store pipeline configuration review. For this release-branch backport, conflict markers were checked, the release-specific PDP path adaptation was reviewed in the staged diff, and RiskREQUIRED: Check exactly one box.
High risk because this changes Microsoft Store listing metadata and release-publishing pipeline behavior. Risk is constrained by preserving the release branch's existing PDP directory layout while applying only the original PR's Store metadata simplification. Merge ConflictsConflicts in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCo-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot App <[email protected]> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
Aditya Patwardhan (adityapatwardhan)
requested a review
from a team
as a code owner
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟡 Changes recommendedAdd a null check before enumerating StoreBroker listing properties. Get a fresh assessment by requesting another Copilot review. Review effort: Lite Open (1)What changed in this PRSimplifies Microsoft Store listing metadata for the Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Comment on lines
+65
to
+68
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
Patrick Meinecke (SeeminglyScience)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
4fe79c0
into
PowerShell:release/v7.4.21
36 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Justin Chung (jshigetomi)
approved these changes
7 of 12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |