GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.4.21] Simplify Microsoft Store listing metadata by adityapatwardhan · Pull Request #28050 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Sep 21, 2026

Copy link
Copy Markdown
Member

Backport of #27968 to release/v7.4.21

Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Required release tooling change that makes the static PDP the source of Store listing language, limits publishing-time substitutions to version values, removes obsolete AppStoreName mutation, and supplies the PDP root for StoreBroker's required media-root input.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

The original change was validated through Store pipeline configuration review. For this release-branch backport, conflict markers were checked, the release-specific PDP path adaptation was reviewed in the staged diff, and git diff --check upstream/release/v7.4.21...HEAD passed. Full release pipeline validation is delegated to PR CI.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

High risk because this changes Microsoft Store listing metadata and release-publishing pipeline behavior. Risk is constrained by preserving the release branch's existing PDP directory layout while applying only the original PR's Store metadata simplification.

Merge Conflicts

Conflicts in .pipelines/templates/package-store-package.yml and assets/AppxManifest.xml were caused by the release branch's singular .pipelines/store/PDP layout and older one-language manifest. Resolution preserved the release path, removed runtime AppStoreName mutation, reused the PDP root as the media root, removed the obsolete PDP-Media placeholder, and applied the localized manifest resource list.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jshigetomi Justin Chung
@adityapatwardhan
Simplify Microsoft Store listing metadata (PowerShell#27968)
445c4b7
Co-authored-by: Justin Chung <[email protected]>
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
Copilot AI lite review requested due to automatic review settings September 21, 2026 22:45
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from a team as a code owner September 21, 2026 22:45
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 21, 2026
@azure-pipelines

azure-pipelines Bot commented Sep 21, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Aditya Patwardhan (adityapatwardhan) September 21, 2026 22:45
View session
Copilot AI reviewed Sep 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add a null check before enumerating StoreBroker listing properties.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
  • Medium severity Check listings for null before enumerating properties · New
What changed in this PR

Simplifies Microsoft Store listing metadata for the release/v7.4.21 branch.

Changes:

  • Uses static PDP content with release-time substitutions.
  • Removes obsolete AppStoreName and media configuration.
  • Adds localized manifest resources and reuses the PDP root for media input.
File Description
assets/​AppxManifest.xml Adds supported resource languages.
.pipelines/​templates/​release-MSIX-Publish.yml Substitutes release-note placeholders during publishing.
.pipelines/​templates/​package-store-package.yml Removes obsolete PDP mutation and reuses the PDP root.
.pipelines/​store/​SBConfig.json Removes obsolete media settings.
.pipelines/​store/​PDP/​PDP/​en-US/​PDP.xml Defines static release-note content.
.pipelines/​store/​PDP/​PDP-Media/​en-US/​.gitkeep Removes the obsolete media placeholder.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .pipelines/templates/release-MSIX-Publish.yml
Comment on lines +65 to +68
$listingProperties = @($json.listings.PSObject.Properties)
if ($listingProperties.Count -eq 0) {
throw "Store listings are missing from '$jsonPath'."
}
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) enabled auto-merge (squash) September 22, 2026 19:19
SeeminglyScience
Patrick Meinecke (SeeminglyScience) approved these changes Sep 22, 2026
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 4fe79c0 into PowerShell:release/v7.4.21 Sep 22, 2026
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

jshigetomi
Justin Chung (jshigetomi) approved these changes Sep 23, 2026
View reviewed changes
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Sep 24, 2026
[release/v7.4.21] Remove unintended Microsoft Store languages #28077
Merged
7 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SeeminglyScience Patrick Meinecke (SeeminglyScience) SeeminglyScience approved these changes
@jshigetomi Justin Chung (jshigetomi) jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @SeeminglyScience @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.