GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand by adityapatwardhan · Pull Request #28059 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Sep 22, 2026

Copy link
Copy Markdown
Member

Backport of #25557 to release/v7.4.21

Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Travis Plunk (@TravisEz13)

Original CL Label: CL-General

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Restores Show-Command module import/command refresh behavior and prevents Show-Command from running in unsupported restricted remoting sessions, where it now terminates with a clear error.

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

The regression was introduced by PR #20593.

Testing

Verified that the cherry-picked commit is exactly one commit ahead of upstream/release/v7.4.21, reviewed the resulting three-file diff against the original PR diff, and ran git diff --check successfully. Direct project builds were attempted but could not complete because the local checkout lacks generated restore/resource prerequisites (project.assets.json and DotNetEventingStrings); supported CI validation is required.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Medium risk because this changes customer-facing Show-Command behavior and restricted-remoting error handling. The change is narrowly scoped to restoring the module-import helper, adding one session restriction guard, and adding its resource string; it cherry-picked without conflicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13 @adityapatwardhan
Add GetImportModuleCommand method back and check for session restri…
eaf311d 
…ction in `ShowCommand` (PowerShell#25557)
Copilot AI lite review requested due to automatic review settings September 22, 2026 18:26
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 22, 2026
@azure-pipelines

azure-pipelines Bot commented Sep 22, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of Aditya Patwardhan (adityapatwardhan) September 22, 2026 18:30
View session
Copilot AI reviewed Sep 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Fix the remote refresh script separator issue; also correct the isFirstChance documentation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
  • Medium severity Add statement separator before serialized Show-Command script · New
  • Low severity Correct isFirstChance XML documentation · New
What changed in this PR

Backports Show-Command fixes to restore module refresh behavior and reject unsupported restricted sessions.

Changes:

  • Restores module import and command refresh scripting.
  • Adds a restricted-session guard.
  • Adds the corresponding error resource.
File Summary
src/​System.Management.Automation/​resources/​HelpErrors.resx Adds the restricted-session error message.
src/​Microsoft.PowerShell.Commands.Utility/​commands/​utility/​ShowCommand/​ShowCommand.cs Adds the restricted-session guard.
src/​Microsoft.Management.UI.Internal/​commandHelpers/​ShowCommandHelper.cs Restores module import scripting; has an unresolved moderate issue (3 votes) requiring a statement separator, plus a documentation nit (3 votes).

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs
}
else
{
scriptBase += GetSerializedCommandScript();
Comment thread src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs
/// </summary>
/// <param name="module">Module we want to import.</param>
/// <param name="isRemoteRunspace">Boolean flag determining whether Show-Command is queried in the local or remote runspace scenario.</param>
/// <param name="isFirstChance">Boolean flag to indicate that it is the second attempt to query Show-Command data.</param>
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) enabled auto-merge (squash) September 22, 2026 19:04
SeeminglyScience
Patrick Meinecke (SeeminglyScience) approved these changes Sep 22, 2026
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title [release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand WIP: [release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand Sep 22, 2026
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: [release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand [release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand Sep 22, 2026
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 37b5998 into PowerShell:release/v7.4.21 Sep 22, 2026
38 of 39 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the backport/release/v7.4.21/25557-eef085210 branch September 22, 2026 20:20
jshigetomi
Justin Chung (jshigetomi) approved these changes Sep 23, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SeeminglyScience Patrick Meinecke (SeeminglyScience) SeeminglyScience approved these changes
@jshigetomi Justin Chung (jshigetomi) jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adityapatwardhan @SeeminglyScience @jshigetomi @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.