GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — [release/v7.5.12] Simplify Microsoft Store listing metadata by adityapatwardhan · Pull Request #28063 · PowerShell/PowerShell Conversation
Member
Backport of #27968 to release/v7.5.12 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Required Store release tooling change that makes the PDP the static source for localized listing metadata and limits publishing-time updates to version-specific placeholders. Customer Impact
RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingThe cherry-pick was adapted using the conflict resolutions from the already merged release/v7.4.21 backport. The final backport has a clean worktree, passes git diff --check and conflict-marker scanning, and both AppxManifest.xml and PDP.xml parse as XML while SBConfig.json parses successfully as JSON. RiskREQUIRED: Check exactly one box.
High risk because this changes Microsoft Store packaging and listing metadata. Risk is constrained by using the same conflict resolutions already merged for the 7.4 release branch and by validating the resulting XML, JSON, diff hygiene, and absence of conflict markers. Merge ConflictsConflicts occurred in .pipelines/templates/package-store-package.yml and assets/AppxManifest.xml because the 7.5 release branch retained older PDP mutation logic and a single en-us resource entry. Resolved by applying the same release-appropriate changes used in the already merged 7.4 backport: remove AppStoreName/PDP mutation, reuse the PDP root as the required media root, and add the localized manifest resource declarations. Release-branch paths and structure were preserved.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCo-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot App <[email protected]> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]>
Aditya Patwardhan (adityapatwardhan)
requested a review
from a team
as a code owner
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🔵 Needs a closer lookHigh-risk Microsoft Store packaging changes require human review, and the tracked PDP-Media placeholder remains to be removed. Review effort: Lite What changed in this PRSimplifies Microsoft Store listing metadata by making PDP content static and limiting publish-time substitutions. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Dongbo Wang (daxian-dbw)
requested changes
Uh oh!
There was an error while loading. Please reload this page.
Justin Chung (jshigetomi)
approved these changes
Co-authored-by: Dongbo Wang <[email protected]>
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
Dongbo Wang (daxian-dbw)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
4482ba3
into
PowerShell:release/v7.5.12
35 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.5.12/27968-8e1675f17
branch
7 of 12 tasks
3 of 9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |