GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — [release/v7.5.12] Add the needed variable groups to the MSIX VPack pipeline to enforce using the production ADO feed by adityapatwardhan · Pull Request #28065 · PowerShell/PowerShell Conversation
Member
Backport of #27896 to release/v7.5.12 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Dongbo Wang (@daxian-dbw) Original CL Label: CL-BuildPackaging /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Required build tooling change so the MSIX vPack pipeline can authenticate to and pull required packages through the production Azure DevOps feed. Customer Impact
RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingThe backport cherry-picked cleanly, the resulting YAML diff passes git diff --check, and the final diff was reviewed to confirm that it only adds the mscodehub-feed-read-general and mscodehub-feed-read-akv variable groups to the MSIX vPack pipeline. RiskREQUIRED: Check exactly one box.
Medium risk because this changes credential-bearing variable group availability in the official MSIX vPack pipeline. The change is limited to adding the two established production-feed variable groups and cherry-picked cleanly.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…using the production ADO feed (PowerShell#27896)
Aditya Patwardhan (adityapatwardhan)
requested a review
from a team
as a code owner
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟢 Approval recommendedNo unresolved review issues; the scoped change enables authenticated production feed retrieval. Review effort: Lite What changed in this PRAdds production Azure DevOps feed variable groups to the official MSIX vPack pipeline. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Dongbo Wang (daxian-dbw)
approved these changes
Justin Chung (jshigetomi)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
8a8ffc2
into
PowerShell:release/v7.5.12
35 of 39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.5.12/27896-ea61eef28
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-BuildPackaging
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |