GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — [release/v7.5.12] Tolerate IO/JSON errors reading the per-user `powershell.config.json` by adityapatwardhan · Pull Request #28070 · PowerShell/PowerShell Conversation
Member
Backport of #27373 to release/v7.5.12 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi) Original CL Label: CL-Engine /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Customer Impact
Found internally after reports of PowerShell failing at startup when a per-user powershell.config.json is temporarily unreadable or malformed. The expected behavior is to warn and fall back to defaults for the current-user file while retaining strict failure for the system-wide configuration. RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingThe original PR adds focused xUnit coverage for broken and type-mismatched current-user configuration, fallback defaults, warning emission, and continued system-wide strict failure. The backport cherry-picked cleanly and passes git diff --check, resource XML parsing, and conflict-marker scanning. A targeted dotnet test attempt was blocked during build by pre-existing missing DotNetEventingStrings generated resources in Microsoft.PowerShell.CoreCLR.Eventing, before the selected tests could run. RiskREQUIRED: Check exactly one box.
Medium risk because this changes early startup configuration error handling, but only for the per-user scope; the system-wide security-relevant configuration remains fail-closed. The original change includes focused xUnit coverage and cherry-picked cleanly.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…PowerShell#27373) Co-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟡 Changes recommendedInaccessible files can be treated as missing, bypassing warnings and strict system-wide failure. Get a fresh assessment by requesting another Copilot review. Review effort: Lite What changed in this PRBackports tolerant handling for malformed or unreadable per-user PowerShell configuration while retaining strict system-wide behavior. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Comment on lines
+415
to
+417
Dongbo Wang (daxian-dbw)
approved these changes
Justin Chung (jshigetomi)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
8a32d84
into
PowerShell:release/v7.5.12
36 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.5.12/27373-84a930151
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-Engine
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |