GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [release/v7.5.12] Add GetImportModuleCommand method and session restriction check in ShowCommand by adityapatwardhan · Pull Request #28073 · PowerShell/PowerShell

Conversation

Aditya Patwardhan (adityapatwardhan) commented Sep 23, 2026

Copy link

Copy Markdown

Member

Backport of #25557 to release/v7.5.12

Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Travis Plunk (@TravisEz13)

Original CL Label: CL-General

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

Required tooling change
Optional tooling change (include reasoning)

Customer Impact

Customer reported
Found internally

Fixes #25556, where Show-Command lacks the module import helper behavior and can run in unsupported restricted remoting sessions instead of returning a clear terminating error.

Regression

REQUIRED: Check exactly one box.

The Show-Command behavior regression was introduced by #20593.

Testing

The backport cherry-picked cleanly and passes git diff --check and HelpErrors.resx XML parsing. Builds of the two affected projects were attempted after restoring dependencies but were blocked in an unrelated dependency project by missing generated DotNetEventingStrings resources in Microsoft.PowerShell.CoreCLR.Eventing.

Risk

REQUIRED: Check exactly one box.

High
Medium
Low

Medium risk because this changes Show-Command behavior and module-import script generation, but the changes are limited to the graphical host helper and an explicit restricted-session guard. The backport cherry-picked cleanly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add GetImportModuleCommand method back and check for session restri…

5b0bfde

…ction in `ShowCommand` (PowerShell#25557)

Copilot AI lite review requested due to automatic review settings

September 23, 2026 18:53

Aditya Patwardhan (adityapatwardhan) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label

Sep 23, 2026

azure-pipelines Bot commented Sep 23, 2026

Copy link

Copy Markdown

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Aditya Patwardhan (adityapatwardhan)

September 23, 2026 18:55

View session

Copilot AI reviewed

Sep 23, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The remote fallback is missing a statement separator, producing invalid PowerShell syntax.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 2

Open (3)

Separate module import from serialized PowerShell script · New
Fix duplicated word in summary text · New
Correct documentation for first-attempt flag semantics · New

What changed in this PR

Backports Show-Command module-import support and restricted-session validation to v7.5.12.

Changes:

Adds module-import command generation.
Rejects unsupported restricted sessions.
Adds the localized error resource.

File	Description
`src/System.Management.Automation/resources/HelpErrors.resx`	Adds the restricted-session error message.
`src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs`	Adds restricted-session validation.
`src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs`	Generates module-import and refresh commands.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs

		}
		else
		{
		scriptBase += GetSerializedCommandScript();

Comment thread

src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs

Comment on lines +493 to +494

		/// Gets the command to be run to in order to import a module and refresh the command data.
		/// </summary>

Comment thread

src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs

		/// </summary>
		/// <param name="module">Module we want to import.</param>
		/// <param name="isRemoteRunspace">Boolean flag determining whether Show-Command is queried in the local or remote runspace scenario.</param>
		/// <param name="isFirstChance">Boolean flag to indicate that it is the second attempt to query Show-Command data.</param>

Dongbo Wang (daxian-dbw) approved these changes

Sep 23, 2026

View reviewed changes

Justin Chung (jshigetomi) approved these changes

Sep 23, 2026

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit a78ac39 into PowerShell:release/v7.5.12

Sep 23, 2026

36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) deleted the backport/release/v7.5.12/25557-eef085210 branch

September 23, 2026 21:21

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

Dongbo Wang (daxian-dbw)

daxian-dbw approved these changes

Justin Chung (jshigetomi)

jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-General

Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.