GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — [release/v7.6.7] Tolerate IO/JSON errors reading the per-user `powershell.config.json` by adityapatwardhan · Pull Request #28084 · PowerShell/PowerShell Conversation
Member
Backport of #27373 to release/v7.6.7 Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi) Original CL Label: CL-Engine /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Customer Impact
Fixes #27370, where PowerShell can fail during startup when the per-user powershell.config.json is unreadable because a cloud file provider such as OneDrive is not running, access is denied, JSON is malformed, or a value has the wrong shape. Expected behavior is a warning and fallback to default current-user settings; system-wide configuration errors remain hard failures. RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingThe original PR added xUnit coverage for malformed and unreadable current-user configuration files, type-mismatched values, fallback-to-default behavior, warning emission to stderr, and continued strict failure for the all-users configuration. The backport cherry-picked cleanly onto the latest upstream release/v7.6.7; the worktree is clean, the branch is exactly one commit ahead of the target, and git diff --check passed. CI will provide release-branch build and test validation. RiskREQUIRED: Check exactly one box.
Medium risk because this changes early-startup configuration handling in the engine. The change is scoped to current-user configuration failures, preserves fail-closed behavior for the security-relevant all-users configuration, and includes focused xUnit coverage for both fallback paths and warning output.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…PowerShell#27373) Co-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟡 Changes recommendedUnresolved handling and test coverage gaps affect the promised behavior. Get a fresh assessment by requesting another Copilot review. Review effort: Lite Open (1)What changed in this PRThis backport makes per-user configuration errors non-fatal while preserving strict system-wide configuration handling. Changes:
Unresolved issues remain around unreadable-file warning behavior and coverage for I/O and security-sensitive configuration cases.
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Comment on lines
+415
to
+417
Justin Chung (jshigetomi)
approved these changes
Aditya Patwardhan (adityapatwardhan)
merged commit
b613dd7
into
PowerShell:release/v7.6.7
44 of 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.6.7/27373-84a930151
branch
5 tasks done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-Engine
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |