GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||
GeezerVison is showing github.com — [release/v7.6.7] Handle MSIX installation specially when prepend to PATH by daxian-dbw · Pull Request #28091 · PowerShell/PowerShell Conversation
Member
Backport of #27782 to release/v7.6.7 Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw) Original CL Label: CL-General /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Customer Impact
Fixes an issue where, on MSIX-packaged PowerShell installations, the $PSHOME directory (which contains a version number) was prepended to PATH at startup. Because this path changes on every MSIX update, cached references to it (e.g., by cmake) become invalid after an update. The fix uses the stable ExecutionAlias directory instead. RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingOriginal PR was manually tested against MSIX-packaged PowerShell installations, verifying that the ExecutionAlias directory is prepended to PATH instead of the version-specific $PSHOME path, and that this remains stable across MSIX package updates. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7. RiskREQUIRED: Check exactly one box.
Medium risk: changes core startup logic that modifies the PATH environment variable, but the change is narrowly scoped to MSIX installation detection and doesn't affect non-MSIX installations. The fix addresses a real reliability issue where PATH entries become invalid after an MSIX update.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…7782) Update the code that prepends `$PSHOME` to `PATH` to handle the MSIX package installation specially -- it uses the stable path that points to the `ExecutionAlias` of the MSIX installation instead of `$PSHOME`.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟡 Changes recommendedUnresolved MSIX detection issues and insufficient, duplicated test coverage must be addressed. Get a fresh assessment by requesting another Copilot review. Review effort: Lite Open (2)What changed in this PRBackports the MSIX PATH handling fix so PowerShell uses a stable execution-alias directory instead of the versioned package path. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dongbo Wang (daxian-dbw)
merged commit
df0dc57
into
PowerShell:release/v7.6.7
36 of 39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.7/27782-d0f43b003
branch
3 of 9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-General
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |