GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — [release/v7.6.7] Mark DSC Profile tests pending on MSIX test runs by daxian-dbw · Pull Request #28092 · PowerShell/PowerShell Conversation
Member
Backport of #27884 to release/v7.6.7 Triggered by Dongbo Wang (@daxian-dbw) on behalf of Aditya Patwardhan (@adityapatwardhan) Original CL Label: CL-Test /cc @PowerShell/powershell-maintainers ImpactREQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected. Tooling Impact
Prevents false test failures in CI/test runs against MSIX-packaged PowerShell builds by marking known-incompatible DSC Profile tests as pending rather than failing. Customer Impact
RegressionREQUIRED: Check exactly one box.
This is not a regression. TestingOriginal PR was verified by running the DSC profile resource test suite in both MSIX and non-MSIX test contexts, confirming tests are marked pending only under MSIX. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7. RiskREQUIRED: Check exactly one box.
Low risk: test-only change that detects MSIX-packaged test runs and marks known-incompatible DSC profile tests as pending instead of failing. No product code is modified.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCo-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot App <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot review overview🟢 Approval recommendedNo unresolved review issues were identified. Review effort: Lite What changed in this PRUpdates DSC profile tests to prevent false failures in MSIX-packaged PowerShell environments. Changes:
💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dongbo Wang (daxian-dbw)
merged commit
2c3e458
into
PowerShell:release/v7.6.7
37 of 38 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.7/27884-9e734952a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-Test
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |