GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [release/v7.6.7] Add PDP.xml to the `LocProject.json` file by daxian-dbw · Pull Request #28095 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 24, 2026

Copy link
Copy Markdown
Member

Backport of #27966 to release/v7.6.7

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Enables localization of the Microsoft Store listing PDP.xml strings by adding it to LocProject.json and updating pipeline template paths to the renamed store/PDPs folder structure.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Verified by confirming the pipeline templates correctly reference the renamed store/PDPs path and that LocProject.json includes PDP.xml as a LocItem with the LangIDOnPath copy option. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7 (after upstream/release/v7.6.7 was updated to include the revert of a previously mis-ordered backport of a dependent PR).

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Low risk: build/packaging tooling change that renames the store/PDP folder to store/PDPs and adds PDP.xml as a LocItem in LocProject.json so its strings can be localized. Does not affect product runtime behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Add PDP.xml to the LocProject.json file for localization (PowerSh…
02b6148 
…ell#27966)
Copilot AI lite review requested due to automatic review settings September 24, 2026 21:27
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Justin Chung (jshigetomi) as a code owner September 24, 2026 21:27
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner September 24, 2026 21:27
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2026
@azure-pipelines

azure-pipelines Bot commented Sep 24, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) September 24, 2026 21:28
View session
Copilot AI reviewed Sep 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update the localization tests to support the new XML item before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
  • High severity Update LocProject tests to handle XML localization entries · New
What changed in this PR

Backports Microsoft Store PDP localization support to release/v7.6.7 and updates packaging paths to the renamed PDPs structure.

Changes:

  • Registers PDP.xml for localization.
  • Updates StoreBroker PDP and media paths.
  • Adds PDP metadata and media directory structure.
File Summary
Localize/​LocProject.json Adds PDP localization configuration; associated localization tests require updates for XML items.
.pipelines/​templates/​package-store-package.yml Updates StoreBroker paths to PDPs.
.pipelines/​store/​PDPs/​PDP/​en-US/​PDP.xml Adds Store listing metadata; contains a minor grammar issue.
.pipelines/​store/​PDPs/​PDP-Media/​en-US/​.gitkeep Preserves the localized media directory.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Localize/LocProject.json
},
{
"SourceFile": ".pipelines\\store\\PDPs\\PDP\\en-US\\PDP.xml",
"CopyOption": "LangIDOnPath",
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 24, 2026
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Sep 24, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4879358 into PowerShell:release/v7.6.7 Sep 24, 2026
37 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.7/27966-b664c2e02 branch September 24, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@jshigetomi Justin Chung (jshigetomi) Awaiting requested review from jshigetomi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.