GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [release/v7.6.7] Fix `LocProject.json` tests and trigger CIs on changes to `LocProject.json` by daxian-dbw · Pull Request #28104 · PowerShell/PowerShell

Conversation

Dongbo Wang (daxian-dbw) commented Sep 24, 2026

Copy link

Copy Markdown

Member

Backport of #27988 to release/v7.6.7

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-Test

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

Required tooling change
Optional tooling change (include reasoning)

Fixes broken LocProject.json tests and ensures CI pipelines trigger correctly when LocProject.json is modified, improving localization tooling reliability.

Customer Impact

Customer reported
Found internally

Regression

REQUIRED: Check exactly one box.

This is not a regression.

Testing

Original PR fixed the LocProject.json test suite and added CI triggers for changes to that file; verified by confirming the tests pass and CI runs on LocProject.json edits. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7.

Risk

REQUIRED: Check exactly one box.

High
Medium
Low

Low risk: fixes existing localization test coverage and ensures CI is triggered on LocProject.json changes. No product runtime code is modified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix LocProject.json tests and trigger CIs on changes to `LocProject…

f84ca16

….json` (PowerShell#27988)

Dongbo Wang (daxian-dbw) requested review from a team and Justin Chung (jshigetomi) as code owners

September 24, 2026 22:58

Copilot AI lite review requested due to automatic review settings

September 24, 2026 22:58

Dongbo Wang (daxian-dbw) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label

Sep 24, 2026

azure-pipelines Bot commented Sep 24, 2026

Copy link

Copy Markdown

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw)

September 24, 2026 22:59

View session

Copilot AI reviewed

Sep 24, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The critical resource-count test assertion cannot pass with the current repository layout.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Fix resource directory search to count all .resx files · New

What changed in this PR

Backports localization validation fixes and ensures CI runs when LocProject.json changes.

Changes:

Separates .resx and .xml validation and counts.
Adds LocProject.json to source-change detection.

File	Summary
`test/powershell/engine/ResourceValidation/LocProject.Tests.ps1`	Updates validation, but the resource-count assertion remains unable to find nested resource directories.
`.github/actions/infrastructure/path-filters/action.yml`	Includes `LocProject.json` in CI source detection.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/engine/ResourceValidation/LocProject.Tests.ps1

		}

		$project.LocItems.Count \| Should -Be $totalResourceCount
		$resxLocItemCount \| Should -Be $totalResourceCount

Dongbo Wang (daxian-dbw) merged commit 2db50ea into PowerShell:release/v7.6.7

Sep 25, 2026

36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.7/27988-0a64a2d92 branch

September 25, 2026 00:09

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

Justin Chung (jshigetomi)

Awaiting requested review from jshigetomi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-Test

Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.