GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Treat `StringCollection` as a list collection with the `String` element type by daxian-dbw · Pull Request #28141 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Oct 5, 2026

Copy link
Copy Markdown
Member

PR Summary

Fix #27969

Treat StringCollection as a list collection with the String element type.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Treat 'StringCollection' as a list collection with the 'String' eleme…
7109603 
…nt type
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner October 5, 2026 22:43
Copilot AI balanced review requested due to automatic review settings October 5, 2026 22:43
@azure-pipelines

azure-pipelines Bot commented Oct 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 5, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 5, 2026
fix(engine): unwrap scalar PSObject during collection binding #27970
Closed
7 of 11 tasks
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) October 5, 2026 22:46
View session
Copilot AI reviewed Oct 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The targeted binding fix is correct and includes coverage for the regression and preservation behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes scalar PSObject binding to StringCollection parameters by recognizing their string element type.

Changes:

  • Classifies StringCollection as an IList of strings.
  • Adds regression tests for scalar, multiple, and untyped-list binding.
File Description
src/​System.Management.Automation/​engine/​CompiledCommandParameter.cs Adds StringCollection element-type metadata.
test/​powershell/​Language/​Parser/​ParameterBinding.Tests.ps1 Adds parameter-binding regression coverage.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iSazonov
Ilya (iSazonov) approved these changes Oct 6, 2026
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) added the Backport-7.7.x-Consider label Oct 8, 2026
jshigetomi
Justin Chung (jshigetomi) approved these changes Oct 9, 2026
View reviewed changes

@jshigetomi Justin Chung (jshigetomi) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the targeted StringCollection parameter-binding fix and its regression coverage. No merge blockers found.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit bcd1e69 into PowerShell:master Oct 9, 2026
37 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the stringcollection-binding branch October 9, 2026 16:37
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.7.x-Done and removed Backport-7.7.x-Consider labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@jshigetomi Justin Chung (jshigetomi) jshigetomi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.7.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Binary cmdlet binding fails to unwrap a scalar PSObject for StringCollection parameters

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @iSazonov @jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.