GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Remove unused 'pull-requests: read' permission from the labels workflow by yuunnn · Pull Request #28241 · PowerShell/PowerShell Conversation
Contributor
PR SummaryFixes #28194.
PR ContextRemoving the scope keeps the workflow working and reduces the token permissions granted to the job, in line with the principle of least privilege. The token minted for this workflow is available to every step, including the third-party actions pinned in it. PR Checklist
ValidationThe change only removes a permission that is not consumed. The
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
吴旭云 (yuunnn)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedLabel validation reads the webhook payload without API calls, and checkout retains its required permission. No open issues 🎉 What changed in this PRAddresses #28194 by reducing token permissions in the label-validation workflow. Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Dongbo Wang (daxian-dbw)
approved these changes
Dongbo Wang (daxian-dbw)
merged commit
c28aa00
into
PowerShell:master
36 of 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
CL-General
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Workflow labels.yml grants pull-requests: read that no step usesUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |