GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Stop enforcing invariant culture in build pipelines by daxian-dbw · Pull Request #28260 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Oct 25, 2026

Copy link
Copy Markdown
Member

PR Summary

With the environment variable DOTNET_SYSTEM_GLOBALIZATION_INVARIANT set to true, only invariant culture is allowed in the build pipelines. However, the default culture of the build image is en-US, and therefore that env var causes failure when loading the Microsoft.PowerShell.Archive module because the module runs Import-LocalizedData using the default culture en-US, which gets blocked.

This PR stops enforcing invariant culture in build pipelines by removing those 2 env vars.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Dongbo Wang (daxian-dbw) added 2 commits October 25, 2026 11:24
@daxian-dbw
Merged PR 42309: Set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT to false t…
1a84540 
…o allow use non-invariant culture

Set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT to false to avoid Archive module loading issue

Cherry picked from !42308

----
#### AI description  (iteration 1)
#### PR Classification
Configuration change to fix a bug preventing use of non-invariant culture.

#### PR Summary
Sets `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` to `false` in pipeline variable templates to allow non-invariant culture usage.
- `PowerShell-Coordinated_Packages-Variables.yml`: changed `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` value from `true` to `false`.
- `PowerShell-Release-Variables.yml`: changed `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` value from `true` to `false`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
@daxian-dbw
Remove the env var
562bd7b
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from a team and Justin Chung (jshigetomi) as code owners October 25, 2026 18:36
Copilot AI balanced review requested due to automatic review settings October 25, 2026 18:36
@azure-pipelines

azure-pipelines Bot commented Oct 25, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 25, 2026
Copilot started reviewing on behalf of Dongbo Wang (daxian-dbw) October 25, 2026 18:37
View session
@microsoft-github-policy-service microsoft-github-policy-service Bot added Backport-7.4.x-Consider Backport-7.5.x-Consider Backport-7.6.x-Consider labels Oct 25, 2026
SeeminglyScience
Patrick Meinecke (SeeminglyScience) approved these changes Oct 25, 2026
View reviewed changes
Copilot AI reviewed Oct 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Linux pipeline validation is needed to confirm that removing the ICU workaround does not reintroduce BinSkim failures.

No open issues 🎉

What changed in this PR

Removes pipeline-wide invariant globalization settings so culture-dependent operations, including loading Microsoft.PowerShell.Archive, can use the build image’s default en-US culture.

Changes:

  • Removes DOTNET_SYSTEM_GLOBALIZATION_INVARIANT from both shared pipeline variable templates.
  • Removes the associated comments describing the Linux BinSkim ICU workaround.
File Description
.pipelines/​templates/​variables/​PowerShell-Release-Variables.yml Stops enforcing invariant globalization in release pipelines.
.pipelines/​templates/​variables/​PowerShell-Coordinated_Packages-Variables.yml Stops enforcing invariant globalization in coordinated packaging pipelines.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 25, 2026
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 46f6096 into PowerShell:master Oct 26, 2026
38 of 39 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the not-enforce-invariant branch October 26, 2026 15:28
@daxian-dbw Dongbo Wang (daxian-dbw) added Backport-7.7.x-Consider Backport-7.7.x-Done and removed Backport-7.7.x-Consider labels Oct 26, 2026
@daxian-dbw Dongbo Wang (daxian-dbw) removed Backport-7.4.x-Consider Backport-7.5.x-Consider Backport-7.6.x-Consider labels Nov 3, 2026
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

The equivalent of the changes was already in the 7.4/7.5/7.6 release branches. Now we only need to make sure this gets ported to 7.7.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@SeeminglyScience Patrick Meinecke (SeeminglyScience) SeeminglyScience approved these changes
@jshigetomi Justin Chung (jshigetomi) Awaiting requested review from jshigetomi jshigetomi is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.7.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @adityapatwardhan @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.