GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix release automation test defects by jshigetomi · Pull Request #28285 · PowerShell/PowerShell

Conversation

@jshigetomi

@jshigetomi Justin Chung (jshigetomi) commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes six confirmed defects found while triaging the PowerShell 7.7.0-rc.1 release-automation test failures:

  • fail the startup assembly test only for unexpected additions, while retaining diagnostics for missing historical assemblies
  • bound and clean up timed-out external clipboard helpers before reading process state
  • preserve ModulePath setup errors and normalize logical paths without requiring them to exist
  • retain job state, import errors, verbose output, paths, and hashes for executable-manifest tests
  • make remote-session creation terminate and prevent null-session setup cascades
  • calculate the expected MSIX PATH from package identity, including loose MSIX registration

The unconfirmed macOS SSH exception-mapping failure is intentionally unchanged pending reproducible SSH/DNS evidence.

PR Context

The 7.7.0-rc.1 release-automation comparison reported 19 new failures. Several were false failures or setup/diagnostic defects that prevented the tests from validating product behavior. The clipboard failure also exposed a product bug where Process.ExitCode was read after a timed wait returned false.

Validation:

  • Import-Module .\tools\ci.psm1; Start-PSBuild -CI — Debug build passed; the optional Pester restore reported that PSGallery was unavailable.
  • Import-Module .\tools\ci.psm1; Start-PSBuild -Configuration Release -NoPSModuleRestore — passed.
  • Focused Pester 5 run for falls back when the clipboard helper times out — passed, 1/1.
  • Focused Pester 5 run for pwsh updates PATH correctly even if PATH is not defined — passed, 1/1.
  • Pester 4 run of Import-Module.Tests.ps1 — both changed executable-manifest cases passed; 25 passed and one unrelated existing GAC expectation failed.
  • Focused startup assembly test — the revised assertion correctly rejected separate unexpected assemblies in the local Windows build; the reported RC defect involving only missing historical assemblies is no longer a failure condition.
  • PowerShell parser validation for all changed .ps1 and .psm1 files — passed.
  • ModulePath.Tests.ps1 and the affected implicit-remoting Describe were not run because this session is not elevated.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Justin Chung
Fix release automation test defects
4656c22
Co-authored-by: Copilot App <[email protected]>
@jshigetomi
Justin Chung (jshigetomi) requested a review from a team as a code owner October 29, 2026 19:53
Copilot AI balanced review requested due to automatic review settings October 29, 2026 19:53
Copilot started reviewing on behalf of Justin Chung (jshigetomi) October 29, 2026 19:53
View session
Copilot AI reviewed Oct 29, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Set-Clipboard can still hang on Linux when a background clipboard owner retains redirected pipes, and the regression test can pass without establishing helper startup or verifying termination.

2 open issues
  • High severity Avoid hanging on unused clipboard process streams · New
  • Medium severity Ensure timeout test verifies helper startup and termination · New
What changed in this PR

This PR addresses release-automation test defects and adds clipboard timeout handling to improve validation and diagnostics.

Changes:

  • Update startup assembly and MSIX PATH expectations.
  • Preserve module setup and import errors, and stop remoting setup after session-creation failures.
  • Add clipboard helper timeout cleanup and a regression test.
File Description
test/​tools/​Modules/​HelpersRemoting/​HelpersRemoting.psm1 Make remote-session creation errors terminating.
test/​powershell/​Modules/​Microsoft.PowerShell.Utility/​Implicit.Remoting.Tests.ps1 Reject null sessions before remote setup.
test/​powershell/​Modules/​Microsoft.PowerShell.Management/​Clipboard.Tests.ps1 Add clipboard helper timeout coverage.
test/​powershell/​Modules/​Microsoft.PowerShell.Core/​Import-Module.Tests.ps1 Capture job failures, verbose output, paths, and hashes.
test/​powershell/​Host/​Startup.Tests.ps1 Fail only for unexpected loaded assemblies.
test/​powershell/​Host/​ConsoleHost.Tests.ps1 Derive expected MSIX PATH from package identity.
test/​powershell/​engine/​Module/​ModulePath.Tests.ps1 Surface setup errors and normalize paths without requiring existence.
src/​Microsoft.PowerShell.Commands.Management/​commands/​management/​Clipboard.cs Handle helper timeouts and read redirected output asynchronously.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Clipboard.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Justin Chung and others added 2 commits October 29, 2026 15:32
Justin Chung
Address clipboard process review feedback
40010cf
Co-authored-by: Copilot App <[email protected]>
Justin Chung
Bound clipboard helper stream operations
e429824
Co-authored-by: Copilot App <[email protected]>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Nov 5, 2026
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jshigetomi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.