GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Find help again after the help cache is reset by ChrisTX · Pull Request #28294 · PowerShell/PowerShell ConversationPR SummaryFixes #28274. When
This PR makes The new test in PR Context
I built and tested the change on 7.6.9 ( PR Checklist
🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsWhen Get-Help finds the help of a cmdlet or function in a file, it sets the HelpFile property of the command to the full path of that file, and a full path in HelpFile is loaded directly from then on. Reset(), which runs after Update-Help and when the UI culture changes, cleared the cached help but kept those paths, so the session kept getting the help from the same file: the help Update-Help installed in the CurrentUser scope wasn't found when help in $PSHOME had been loaded before, and the help stayed in the previous UI culture. CommandHelpProvider now keeps the original HelpFile of the commands it changes, and Reset() restores them. Fixes PowerShell#28274 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Christian Pfeiffer (ChrisTX)
requested review from
a team,
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedNo active review issues are recorded for the changes to help rediscovery after cache resets. No open issues 🎉 What changed in this PRFixes #28274 by making Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
At least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
Review - Needed
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Get-Help keeps returning help it already loaded after Update-Help -Scope CurrentUser, which makes HelpSystem.Tests.ps1 flaky when $PSHOME has helpUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |