GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Clear output encodings before the ShellExecute fallback for native commands by b84330808 · Pull Request #28327 · PowerShell/PowerShell ConversationPR SummaryFixes #28225. When a native command fails to start on Windows and it is the only command in the pipeline, PowerShell retries with ShellExecute. That retry turns off the stream redirection but leaves Set-Content notpe.exe 'not an executable' $x = & .\notpe.exe # Program 'notpe.exe' failed to run: StandardOutputEncoding is only supported when standard output is redirected. & .\notpe.exe 2>$null # Program 'notpe.exe' failed to run: StandardErrorEncoding is only supported when standard error is redirected. This change clears both encodings together with the redirection flags. With it, both forms report the real start error, the same as PR ContextThe encodings were added for redirected native output, but the ShellExecute fallback was not updated to clear them, so any captured native command that needs the fallback fails with an unrelated The new test (Windows only) runs a non-PE PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…mmands When a native command whose stdout or stderr is captured fails to start, the ShellExecute fallback turns off the stream redirection but keeps `StandardOutputEncoding` and `StandardErrorEncoding`. `Process.Start` then throws "StandardOutputEncoding is only supported when standard output is redirected", so ShellExecute is never tried and the real start error is lost. Clear both encodings together with the redirection flags. Fixes PowerShell#28225
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedNo active review issues were identified in the change to preserve native-command launch errors during the Windows ShellExecute fallback. No open issues 🎉 What changed in this PRFixes #28225 by clearing output encodings before Windows retries a native command with ShellExecute, preventing an encoding validation error from masking the launch failure. Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
At least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
Review - Needed
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Captured native command that fails to start reports 'StandardOutputEncoding is only supported when standard output is redirected' instead of the real launch errorUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |