GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge 6.0.0 rc.2 changes by TravisEz13 · Pull Request #5606 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Dec 2, 2017

Copy link
Copy Markdown
Member

Merge the following PR to 6.0.0-rc.2:
#5580
#4780
#5432
#5593
#5595
#5596

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Dan Travison (dantraMSFT) and others added 6 commits December 1, 2017 16:14
@dantraMSFT @TravisEz13
Use explicit libpsl-native binary name for dllimport. (PowerShell#5580)
1c59cf3
@chunqingchen @TravisEz13
Fix xunnit test for PS (PowerShell#4780)
1ed5e7f 
* Initial work to enable xunit

* Moved AssemblyOriginatorKeyFile to csharp.tests.csproj

* Native binary has dylib extension on macOS
@daxian-dbw @TravisEz13
Skip null-element check for collections with a value-type element type (
e3f0ffd 
PowerShell#5432)

* Fix NotNullOrEmpty check logic

* Fix a test issue on Unix
@daxian-dbw @TravisEz13
Update PowerShell executable name in using-vscode.md (PowerShell#5593)
bafca58
@TravisEz13
Remove exclusion for hang and add context exception for remaining ins…
f58fdea 
…tances (PowerShell#5595)
@SteveL-MSFT @TravisEz13
Remove unncessary check for Paths.count > 0 as there is code later to…
72bc90f 
… use the current (PowerShell#5596)

Remove unnecessary check for Paths.count > 0 as there is code later to use the current working directory since -Path is not a mandatory parameter.
Updated ShouldProcess to output the internal action on adding paths rather than the user action (which is the cmdlet name).

Updated tests to not specify -Path

Fix PowerShell#5594
@TravisEz13
Travis Plunk (TravisEz13) requested review from Bruce Payette (BrucePay), Aditya Patwardhan (adityapatwardhan), Dongbo Wang (daxian-dbw) and Jason Shirk (lzybkr) as code owners December 2, 2017 00:18
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 2, 2017
View reviewed changes
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 2, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 2b7c223 into PowerShell:6.0.0 Dec 2, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the move_6.0.0-rc.2_changes branch December 2, 2017 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@lzybkr Jason Shirk (lzybkr) Awaiting requested review from lzybkr

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @daxian-dbw @SteveL-MSFT @dantraMSFT @chunqingchen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.