GeezerVison is showing github.com — WIP Use early preview of .Net Core 3.0 by bergmeister · Pull Request #8370 · PowerShell/PowerShell
Conversation
PR Summary
There are only 1 failing test on Windows due to Compatibility section in application manifest not being embedded in pwsh.exe (https://github.com/dotnet/core-setup/issues/4963).
.Net Core 3.0 adds one reference assembly and also a .nupkg.metadata file for each shipped module containing the hash, which I ignore for the installer.
Removed dependency on rcedit to embed manifest and update assembly file properties as .Net Core 3.0 SDK supports same capabilities from csproj file. Due to this change, the fileversion and productversion embedded as rouces in pwsh.exe has changed to their desired format defined in the csproj. Tests were updated to account for this difference.
.Net Core 3.0 supports writing to reserved device names (like CON which writes to the console as expected; didn't test COM or LPT but presumably they would write to the COM and printer ports), so updated code to only check for CLOCK$ as a reserved device name.
Breaking Change By default, long paths are returned by the FileSystemProvider whereas before, it would retain the short path. This change is due to a change in .Net Core 3.0 behavior related to long paths which invalidated existing tests that used $TestDrive which is built from $env:TEMP which has a short path (if the username is > 8 characters which is the case on AzPipelines for Windows).
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…t (build number does not match sdk)
…o netcore2.2
# Conflicts:
# build.psm1
# test/hosting/hosting.tests.csproj
…o netcore2.2
Conflicts auto-resolved by Tortoise-Git (white space problem only)
# Conflicts:
# assets/files.wxs
…ccore and sos due to the upgrade from preview2 to preview3
… not working with using netcore3.0
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…o netcore3.0
# Conflicts:
# assets/files.wxs
# build.psm1
…o netcore3.0
Mainly resolved by keeping the version of the branch due to the runtime update
# Conflicts:
# PowerShell.Common.props
# assets/files.wxs
# global.json
# test/Test.Common.props
# test/tools/WebListener/WebListener.csproj
|
Reverted attempt to move to newer 3.0 release since it caused more problems
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
We should try the new preview3 that got published yesterday
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Since 6.2-GA was forked we can actively work on the PR.
I think we need rebase and then move to 3.0-Preview3.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I tried to update to preview3 locally but unless I made a mistake, I cannot even do a dotnet restore. It seems there are no matching Asp.Net Core Nuget packages. The version available on NuGet here is only version 3.0.0-preview3-19153-02 and does not match the requirements of projects depending on it. I get lots of errors similar to this:
C:\PowerShell\src\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj : error NU1603: Microsoft.PowerShell.SDK depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved. [C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj]
....
C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj : error NU1603: pwsh depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved.
To me this looks like the Asp.Net Core Team needs to publish a newer preview3 version of their Microsoft.AspNetCore.App Nuget package to fulfill those requirements. Do you know more details Damian Edwards (@DamianEdwards) ?
I pushed to a temporary branch here in this commit, the build here shows the same symptoms that I see locally.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I wonder how we depend on Microsoft.AspNetCore.App?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…o netcore3.0
# Conflicts:
# assets/files.wxs
|
Christoph Bergmeister (@bergmeister) I try to compile your .net v3 branch and found the same symptom.
If I remove 'RuntimeFrameworkVersion' on PowerShell.Common.props and Test.Common.props , it lets me compile.
I also rollback your change to Microsoft.WindowsDesktop.App
branch:netcore3.0_preview3
dotnet.exe -info
.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.0.0-preview3-19153-02 [c:\program files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.0.0-preview3-27503-5 [c:\program files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview3-27504-2 [c:\program files\dotnet\shared\Microsoft.WindowsDesktop.App]
There is a version's conflict between all Microsoft.*.App runtimes and PowerShell.Common.props
I read all previous what's news about dotnet and aspnet, i don't found anything interesting.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Flavien MICHALECZEK (@fMichaleczek) At the moment we are waiting for preview4 to fix problems like that. If you want to try out a working version of netcore3 you could try using a daily build or checkout one of the older commits on this branch that used preview1 or preview2
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Looks like Preview.4 just became available, I'll move the build to that version
|
bergmeister reacted with hooray emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Moving this to a working branch on PS/PS
|
bergmeister reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+2 more reviewers
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
CL-Engine
Indicates that a PR should be marked as an engine change in the Change Log
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|