GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP Use early preview of .Net Core 3.0 by bergmeister · Pull Request #8370 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Nov 30, 2018 •
edited by SteveL-MSFT
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

There are only 1 failing test on Windows due to Compatibility section in application manifest not being embedded in pwsh.exe (https://github.com/dotnet/core-setup/issues/4963).

.Net Core 3.0 adds one reference assembly and also a .nupkg.metadata file for each shipped module containing the hash, which I ignore for the installer.

Removed dependency on rcedit to embed manifest and update assembly file properties as .Net Core 3.0 SDK supports same capabilities from csproj file. Due to this change, the fileversion and productversion embedded as rouces in pwsh.exe has changed to their desired format defined in the csproj. Tests were updated to account for this difference.

.Net Core 3.0 supports writing to reserved device names (like CON which writes to the console as expected; didn't test COM or LPT but presumably they would write to the COM and printer ports), so updated code to only check for CLOCK$ as a reserved device name.

Breaking Change By default, long paths are returned by the FileSystemProvider whereas before, it would retain the short path. This change is due to a change in .Net Core 3.0 behavior related to long paths which invalidated existing tests that used $TestDrive which is built from $env:TEMP which has a short path (if the username is > 8 characters which is the case on AzPipelines for Windows).

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) added 30 commits October 6, 2018 16:38
@bergmeister
try upgrade to 2.2preview2 of .net core
b4687ad
@bergmeister
fix version number of sdk (needs to include build number)
56ba0a1
@bergmeister
[feature] set runtimeversion and revert changes made to alpine docker…
b961bc2
… image creation process
@bergmeister
[feature] Fix NuGet package version of WebListener.csproj test projec…
04f8a7d
…t (build number does not match sdk)
@bergmeister
[feature] Fix WiX file components due to newer versions of DLLS
3571629
@bergmeister
trigger ci
0a61826
@bergmeister
The dotnet-xunit test runner does not work with .Net Core 2.2 and due…
97a67be
… to problems, they have stopped supporting it, therefore use dotnet test as an alternative

xunit/xunit#1675
https://xunit.github.io/releases/2.4
@bergmeister
I forgot that trx format ix VsTest, not NUnit
9c48a7a
@bergmeister
[feature]
91d1c82
@bergmeister
[feature] Fix parameter name due to rename
17fab9b
@bergmeister
[feature] revert to use xml test logger again
5750e86
@bergmeister
[feature] forgot some folder->file reverts
b75514a
@bergmeister
[feature] Update Markdig.Signed NuGet package to 0.15.4 due to new re…
e092441
…lease 2h ago
@bergmeister
[feature] retrigger CI due to sporadic failure
699afb8
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
e8d76e2
…o netcore2.2
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
d4f2fa4
…o netcore2.2

# Conflicts:
#	build.psm1
#	test/hosting/hosting.tests.csproj
@bergmeister
fix merge conflict error to have no diff again in the upstreamed xuni…
7de084d
…t code
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
533b0e0
…o netcore2.2
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
96feacf
…o netcore2.2

Conflicts auto-resolved by Tortoise-Git (white space problem only)
# Conflicts:
#	assets/files.wxs
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
faa0d19
…o netcore2.2
@bergmeister
Update to .Net Core 2.2-preview3
fda3fb9
@bergmeister
[feature] udpate test project version and appveyor cache
8a13d7c
@bergmeister
[feature] Fix MSI installer by updating to the new version of mscorda…
52de7b7
…ccore and sos due to the upgrade from preview2 to preview3
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
580a5ca
…o netcore2.2
@bergmeister
Upgrade to .Net Core 3.0.100-preview-009806 (latest master)
d6f499c
@bergmeister
fix runtime version
0450437
@bergmeister
fix installer and ignore nupkg info files
ede5bc6
@bergmeister
[feature]
7d84226
@bergmeister
update ResGen project to .Net Core 3.9 since 2.0 is deprecated and is…
f7e5127
… not working with using netcore3.0
@bergmeister
[feature] upgrade typegen to .net core 3.0 as well and update comments
b50c906
Steve Lee (POWERSHELL)
[feature] move to .Net Core 3.0 preview 2
8f62ed8
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 29, 2019

Copy link
Copy Markdown
Member

crossgen is returning exit code 139 on Linux and macOS which causes CI to fail. Created https://github.com/dotnet/coreclr/issues/22276

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (POWERSHELL)
[feature] fix case where typegen has an empty string in the file
8013cc6
iSazonov
Ilya (iSazonov) reviewed Jan 30, 2019
View reviewed changes
Comment thread PowerShell.Common.props Resolved

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Jan 30, 2019
.Net Core 3.0 compiler complains about #pragma warning enable xxxx when using C#7.3 dotnet/roslyn#32958
Closed
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
444bd46
…o netcore3.0

# Conflicts:
#	assets/files.wxs
#	build.psm1
@iSazonov Ilya (iSazonov) mentioned this pull request Feb 16, 2019
S.M.A.Language.Compiler doesn't work on .NET Core 3.0 #8880
Closed
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
3528292
…o netcore3.0

Mainly resolved by keeping the version of the branch due to the runtime update
# Conflicts:
#	PowerShell.Common.props
#	assets/files.wxs
#	global.json
#	test/Test.Common.props
#	test/tools/WebListener/WebListener.csproj
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the netcore3.0 branch from 5d91318 to 3528292 Compare February 21, 2019 05:56
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 21, 2019

Copy link
Copy Markdown
Member

Reverted attempt to move to newer 3.0 release since it caused more problems

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

We should try the new preview3 that got published yesterday

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

Since 6.2-GA was forked we can actively work on the PR.
I think we need rebase and then move to 3.0-Preview3.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Mar 8, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I tried to update to preview3 locally but unless I made a mistake, I cannot even do a dotnet restore. It seems there are no matching Asp.Net Core Nuget packages. The version available on NuGet here is only version 3.0.0-preview3-19153-02 and does not match the requirements of projects depending on it. I get lots of errors similar to this:

C:\PowerShell\src\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj : error NU1603: Microsoft.PowerShell.SDK depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved. [C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj]
....
C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj : error NU1603: pwsh depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved.

To me this looks like the Asp.Net Core Team needs to publish a newer preview3 version of their Microsoft.AspNetCore.App Nuget package to fulfill those requirements. Do you know more details Damian Edwards (@DamianEdwards) ?
I pushed to a temporary branch here in this commit, the build here shows the same symptoms that I see locally.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

I wonder how we depend on Microsoft.AspNetCore.App?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Christoph Bergmeister (MVP)
Merge branch 'master' of https://github.com/PowerShell/PowerShell int…
0269ac2
…o netcore3.0

# Conflicts:
#	assets/files.wxs
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Bot (PoshChan) Mar 28, 2019
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Bot (PoshChan) Mar 28, 2019
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Staging (PoshChan-Staging) Mar 28, 2019
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Staging (PoshChan-Staging) Mar 28, 2019
@PowerShell PowerShell Team (PowerShell) deleted a comment from PoshChan-Staging (PoshChan-Staging) Mar 28, 2019
@fMichaleczek

Flavien MICHALECZEK (fMichaleczek) commented Apr 12, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Christoph Bergmeister (@bergmeister) I try to compile your .net v3 branch and found the same symptom.

If I remove 'RuntimeFrameworkVersion' on PowerShell.Common.props and Test.Common.props , it lets me compile.

I also rollback your change to Microsoft.WindowsDesktop.App
branch:netcore3.0_preview3

dotnet.exe -info

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0-preview3-19153-02 [c:\program files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0-preview3-27503-5 [c:\program files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview3-27504-2 [c:\program files\dotnet\shared\Microsoft.WindowsDesktop.App]

There is a version's conflict between all Microsoft.*.App runtimes and PowerShell.Common.props
I read all previous what's news about dotnet and aspnet, i don't found anything interesting.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Apr 12, 2019

Copy link
Copy Markdown
Contributor Author

Flavien MICHALECZEK (@fMichaleczek) At the moment we are waiting for preview4 to fix problems like that. If you want to try out a working version of netcore3 you could try using a daily build or checkout one of the older commits on this branch that used preview1 or preview2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Apr 18, 2019

Copy link
Copy Markdown
Member

Looks like Preview.4 just became available, I'll move the build to that version

bergmeister reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
Steve Lee (SteveL-MSFT) changed the base branch from master to netcore30 April 19, 2019 01:20
@SteveL-MSFT
Merge branch 'netcore30' into netcore3.0
8090588
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Apr 19, 2019

Copy link
Copy Markdown
Member

Moving this to a working branch on PS/PS

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
Steve Lee (SteveL-MSFT) merged commit a27e92b into PowerShell:netcore30 Apr 19, 2019
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.0.0-preview.1 milestone Apr 23, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 23, 2019
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Jan 31, 2020
Cross fails with exit code 139 against PowerShell Core 6 assembly System.Management.Automation.dll dotnet/runtime#11925
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT requested changes
@iSazonov Ilya (iSazonov) iSazonov left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
+2 more reviewers
@JeremyKuhne Jeremy Kuhne (JeremyKuhne) JeremyKuhne left review comments
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@bergmeister @iSazonov @SteveL-MSFT @joeyaiello @fMichaleczek @JeremyKuhne @PaulHigin @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.