GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use compiler flag -gdwarf-5 as per BinSkim by adityapatwardhan · Pull Request #101 · PowerShell/PowerShell-Native

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Mar 27, 2025

Copy link
Copy Markdown
Member

PR Summary

This pull request includes a small change to the src/libpsl-native/CMakeLists.txt file. The change adds the -gdwarf-5 flag to the CMAKE_CXX_FLAGS to enable DWARF version 5 debugging information.

  • src/libpsl-native/CMakeLists.txt: Added -gdwarf-5 to the CMAKE_CXX_FLAGS for improved debugging information.

PR Context

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Use compiler flag -gdwarf-5 as per BinSkim
be1b2d9
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Mar 27, 2025
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 27, 2025

Copy link
Copy Markdown
Member Author

/azp run
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@azure-pipelines

azure-pipelines Bot commented Mar 27, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit dd6951f into PowerShell:master Mar 31, 2025
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the UseGDwarf5 branch March 31, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adityapatwardhan @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.