GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Build for Alpine arm64 and arm32 by adityapatwardhan · Pull Request #72 · PowerShell/PowerShell-Native

Conversation

Aditya Patwardhan (adityapatwardhan) commented Aug 30, 2021

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) added 7 commits

August 27, 2021 13:48


          Intial commit for alpine arm64

70fa8cd


          Update alpine version

23eb8fc


          Changes to build alpine arm64

dd0e15f


          Update python

48a7651


          Fix build switch

b0ea41a


          Fix build dependency list

3fa20e9


          Add missing parameter

32bca8e

Aditya Patwardhan (adityapatwardhan) requested a review from Andy Jordan (andyleejordan)

August 30, 2021 19:53

Andy Jordan (andyleejordan) approved these changes

Aug 30, 2021

View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix typo

Aditya Patwardhan (adityapatwardhan) changed the title ~~Build for Alpine arm64~~ Build for Alpine arm64 and arm32

Sep 1, 2021

Andy Jordan (andyleejordan) reviewed

Sep 2, 2021

View reviewed changes

Comment thread

build.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Andy Jordan (andyleejordan) suggested changes

Sep 2, 2021

View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some stuff 🤞

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) and others added 5 commits

September 7, 2021 12:12


          Apply suggestions from code review

e514d8d

Co-authored-by: Andrew Schwartzmeyer <[email protected]>


          Merge branch 'master' of https://github.com/powershell/powershell-native

f3b1bb3

 into AlpineArm64


          Merge branch 'AlpineArm64' of https://github.com/adityapatwardhan/pow…

369e490

…ershell-native into AlpineArm64


          Add Alpine ARM and Alpine ARM64 to CI and use new YAML tags

29d1f4b


          Fix yaml

a4fedae

Andy Jordan (andyleejordan) approved these changes

Sep 7, 2021

View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do you want to squash and/or rebase the commits?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Aditya Patwardhan (adityapatwardhan) commented Sep 7, 2021

Copy link

Copy Markdown

Member Author

Typically we squash.. I am testing that these bits actually work. Also seems the CI does not upload artifacts.. I will work on that now.

andyleejordan reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

1 more reviewer

Andy Jordan (andyleejordan)

andyleejordan approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.