GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update the Trusted_Platform_Assemblies list by daxian-dbw · Pull Request #83 · PowerShell/PowerShell-Native

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Nov 22, 2022

Copy link
Copy Markdown
Member

PR Summary

Update the Trusted_Platform_Assemblies list to be in sync with the TPA list of pwsh.exe from the min-size build (no WPF related dependencies).

PR Context

The TPA list were not updated for 7.3.0, which caused regression reported: PowerShell/PowerShell#18587

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Dongbo Wang (daxian-dbw) added 2 commits November 22, 2022 15:38
@daxian-dbw
Update the Trusted_Platform_Assemblies list
a382f02
@daxian-dbw
Remove last comma
029b8b9
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Nov 22, 2022
[Regression] PS7.3 - Weird network issues inside Session PowerShell/PowerShell#18587
Closed
5 tasks done
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Nov 22, 2022
View reviewed changes
Comment thread src/powershell-native/nativemsh/pwrshcommon/pwrshcommon.cpp
// NOTE: The names must not include the .dll extension because it will be added programmatically.
static PCSTR trustedAssemblies[] =
{
"getfilesiginforedistwrapper",

@PaulHigin Paul Higinbotham (PaulHigin) Nov 22, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Nov 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new list is generated from the trace output of pwsh.exe (the min-size package, so WPF things are not included) by setting the environment variable COREHOST_TRACE beforehand.
For this specific one, I don't know where it's pulled from.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov

Ilya (iSazonov) commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Maybe add new test in PowerShell repository? We will move to .Net 8 soon...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin Paul Higinbotham (PaulHigin) mentioned this pull request Nov 28, 2022
New-PSSession fails with Could not load file or assembly 'System.Security.Cryptography' PowerShell/PowerShell#18671
Closed
5 tasks done
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 1, 2022
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 99ea9db into PowerShell:master Dec 1, 2022
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the tpalist branch December 1, 2022 22:52
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the Backport-7.3.x label Dec 7, 2022
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.3.x-Done and removed Backport-7.3.x labels Dec 14, 2022
@Tadas Tadas Medišauskas (Tadas) mentioned this pull request Apr 7, 2026
ActiveDirectory module does not work over remoting in PS 7.6 PowerShell/PowerShell#27199
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Backport-7.3.x-Done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @iSazonov @adityapatwardhan @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.