GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FOUR-31702 Self-service task with a timer event to complete the request still appears as active by devmiguelangel · Pull Request #9080 · ProcessMaker/processmaker

Conversation

@devmiguelangel

@devmiguelangel devmiguelangel commented Sep 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

An interrupting boundary timer closes an unclaimed self-service task. The task retains its historical is_self_service = 1 flag, but it must disappear from active Self Service results and must not be labeled Self Service in historical charts.

Solution

  • Do not clear is_self_service, claim/reassign the task, or populate completed_at when an activity closes.
  • Keep the active-list contract query-side: available self-service tasks require status = ACTIVE, remain unassigned, and preserve user/group/manager eligibility. Reuse this predicate for user-ID and assignment-scope listings; the no-auth semantic Self Service query also requires ACTIVE.
  • Preserve raw is_self_service = 1 PMQL semantics for historical/diagnostic searches. The semantic status = "Self Service" filter is the active-availability filter.
  • Add regression coverage for interrupting/non-interrupting timers, closure while the request continues, retained assignment state, active semantic listing versus raw flag query, and assigned historical tasks.

Verification

  • Manual tests were run by the author; all are green.
  • PHP syntax and diff checks pass. No automated test suite was run as part of this change.

Related Tickets & Packages

FOUR-31702
Saved Search PR #701

Code Review Checklist

  • I have pulled this code locally and manually tested it on my instance, along with the associated package.
  • This code includes regression tests for the changed behavior.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This solution does not alter expected process behavior or introduce breaking changes.
  • Enterprise package compatibility and PRD requirements have been verified.

ci:package-savedsearch:FOUR-31702
ci:deploy

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
devmiguelangel added 2 commits September 28, 2026 14:06
@devmiguelangel
feat: fix self-service token claim behavior by ensuring closed tokens…
1221e10
… cannot be claimed.
@devmiguelangel
test: add tests for timer boundary events handling self-service tasks
5130e66
@devmiguelangel devmiguelangel self-assigned this Sep 28, 2026
@cursor

cursor Bot commented Sep 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes shared task-query paths (PMQL Self Service, user_id filter, whereUserAssigned) that drive inbox and saved searches; behavior is narrower but could surprise consumers relying on closed tokens with is_self_service still listed.

Overview
Fixes closed unclaimed self-service tasks still appearing as active when task lists, PMQL, and user filters treat anything with is_self_service = 1 as self-service.

PMQL/advanced Self Service status now requires ACTIVE, unassigned tokens when there is no logged-in user (not only is_self_service). scopeWhereUserAssigned and the tasks API user_id filter no longer inline-match self_service_groups JSON; they orWhereIn token IDs from User::availableSelfServiceTasksQuery(), so closed self-service work drops out while normal assigned (including closed) tasks stay visible.

Adds boundary-timer + self-service feature tests, a BPMN fixture, and filter/API coverage for the new rules.

Reviewed by Cursor Bugbot for commit 6a8f299. Bugbot is set up for automated code reviews on this repo. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@devmiguelangel
devmiguelangel requested a review from pmPaulis September 28, 2026 18:52
@pmPaulis pmPaulis added the version-tbd label Sep 29, 2026
@vladyrichter

vladyrichter commented Sep 30, 2026

Copy link
Copy Markdown

QA server K8S was successfully deployed https://tenant-1.ci-37fb4aefb9.engk8s.processmaker.net

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pmPaulis
pmPaulis approved these changes Oct 1, 2026
View reviewed changes
pmPaulis
pmPaulis requested changes Oct 1, 2026
View reviewed changes
Comment thread ProcessMaker/Repositories/TokenRepository.php Resolved

Uh oh!

There was an error while loading. Please reload this page.

devmiguelangel added 4 commits October 19, 2026 15:44
@devmiguelangel
Merge remote-tracking branch 'origin/develop' into FOUR-31702
c873aef
@devmiguelangel
feat: remove redundant self-service token handling
e62856f
@devmiguelangel
feat: streamline self-service token queries
8081976
@devmiguelangel
test: enhance self-service task filtering and testing
6a8f299
@decisions-sonarqube

decisions-sonarqube Bot commented Oct 19, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@devmiguelangel
devmiguelangel requested a review from pmPaulis October 19, 2026 21:14
pmPaulis
pmPaulis approved these changes Oct 20, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmPaulis pmPaulis pmPaulis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@devmiguelangel devmiguelangel

Labels

version-tbd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@devmiguelangel @vladyrichter @pmPaulis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.