GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed by devmiguelangel · Pull Request #9099 · ProcessMaker/processmaker

Conversation

@devmiguelangel

@devmiguelangel devmiguelangel commented Oct 13, 2026 •
edited by atlassian Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed

An Intermediate Throw Event with two or more incoming sequence flows behaved like an AND-join. TransitionTrait::hasAllRequiredTokens only fired the shared transition when every incoming state had a token, and one firing consumed one token from each incoming flow. When an exclusive or parallel split delivered a token on only some of those flows, the event never fired and the request stayed In Progress.

The event is no longer a join. IntermediateThrowEventTransition fires as soon as any incoming flow has a token and consumes exactly one token per firing, so each arriving token triggers the event and continues downstream. The graph is unchanged: one incoming state per sequence flow, all connected to the same transition. Token persistence and ThrowEventTokenPassed still happen on that transition, which keeps the previous event order for boundary and message tests.

Before this change the transition waited until inA, inB, and inC all held a token. Now a token on any one of them is enough.

Related Tickets

FOUR-6787
ProcessMaker/nayra#240

ci:nayra:FOUR-6787

.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@devmiguelangel
test: add tests for Intermediate Message Throw Event behavior
2e9aed3
@cursor

cursor Bot commented Oct 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only changes (fixture plus feature tests); no application or engine code modified in this diff.

Overview
Adds regression coverage for FOUR-6787: an Intermediate Message Throw Event fed by three exclusive-gateway branches must not behave like an AND-join and block completion.

Introduces tests/Fixtures/four_6787_intermediate_throw_event.json (exclusive gateway → Form Task 1/2/3 → shared node_19 → message end) and IntermediateThrowEventMergeTest, which imports the package, starts a request, completes the gateway branch for select 1, 2, or 3, and asserts the process request reaches COMPLETED in each case.

Reviewed by Cursor Bugbot for commit b194341. Bugbot is set up for automated code reviews on this repo. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@devmiguelangel devmiguelangel changed the title test: add tests for Intermediate Message Throw Event behavior FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed- #240 Oct 13, 2026
@devmiguelangel devmiguelangel self-assigned this Oct 13, 2026
cursor[bot]
cursor Bot reviewed Oct 13, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2e9aed3. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread tests/Feature/IntermediateThrowEventMergeTest.php Resolved

Uh oh!

There was an error while loading. Please reload this page.

devmiguelangel added 2 commits October 13, 2026 15:06
@devmiguelangel
fix: update namespace in IntermediateThrowEventMergeTest
a5c48bb
@devmiguelangel
Merge remote-tracking branch 'origin/develop' into FOUR-6787
c139b50
@devmiguelangel
devmiguelangel requested a review from pmPaulis October 13, 2026 19:38
@devmiguelangel devmiguelangel changed the title FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed- #240 FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed Oct 14, 2026
@devmiguelangel
Merge remote-tracking branch 'origin/develop' into FOUR-6787
b194341
@decisions-sonarqube

decisions-sonarqube Bot commented Oct 14, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pmPaulis
pmPaulis approved these changes Oct 19, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@pmPaulis pmPaulis pmPaulis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@devmiguelangel devmiguelangel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@devmiguelangel @pmPaulis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.