GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove warning when __all__ is a list by jdufresne · Pull Request #227 · PyCQA/pydocstyle

This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Conversation

@jdufresne

@jdufresne jdufresne commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

Refs #62

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sigmavirus24
sigmavirus24 suggested changes Jan 9, 2017
View reviewed changes

@sigmavirus24 sigmavirus24 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this is accepted, you should have tests to ensure that the warning isn't re-added.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jdufresne
Remove warning when __all__ is a list
35077fa 
Refs #62
@jdufresne

jdufresne commented Jan 11, 2017

Copy link
Copy Markdown
Contributor Author

Added test. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Nurdok
Nurdok approved these changes Jan 11, 2017
View reviewed changes
@Nurdok
Nurdok merged commit e416156 into PyCQA:master Jan 11, 2017
@Nurdok

Nurdok commented Jan 11, 2017

Copy link
Copy Markdown
Member

Merged. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@sigmavirus24 sigmavirus24 sigmavirus24 requested changes
@Nurdok Nurdok Nurdok approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jdufresne @Nurdok @sigmavirus24
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.