GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Alternative behavior for exit, help, license builtins by bittner · Pull Request #133 · PythonTurtle/PythonTurtle

Conversation

bittner commented Mar 30, 2019

Copy link

Copy Markdown

Member

Instead of simply deactivating the builtins that cause trouble on the UI we can implement some useful behavior:

exit() should terminate the PythonTurtle application (as it would terminate the Python interpreter)
help(<object>) can show the docstrings of an object
help() can mimic pressing the Help button on the UI
license() opens a web browser on the Python website showing the license (unless we can draw it from the file system)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bittner requested a review from cool-RR

March 30, 2019 12:23

bittner commented

Mar 30, 2019

View reviewed changes

Comment thread

pythonturtle/turtleprocess.py Outdated

		to hide the implementation details from the user.
		"""
		evt = wx.CommandEvent(wx.ID_EXIT, wx.ID_EXIT)
		wx.PostEvent(self.window, evt)

bittner Mar 30, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to fire an "exit the application" event. Unfortunately, this doesn't work. Any idea, @cool-RR?

Unfortunately, brute-force attempts like wx.Abort() behave just like os._exit(0), which makes the application window hang. 😟

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR Mar 30, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about calling the .Close method on the Frame?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bittner Mar 30, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does nothing. It even returns True, which translates to "event was handled". I also tried with force=True, it behaves the same:

self.window.Close(force=true)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR Mar 30, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could investigate but it's not worth the time. As far as I'm concerned you can make exit just do nothing. Honestly this is very esoteric. If you're doing this for fun you can just ask on the wxPython forum and you're likely to get an answer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR approved these changes

Mar 30, 2019

View reviewed changes

cool-RR left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, though I have a few notes about the docstring styling. I prefer:

Triple single quotes instead of triple double quotes.
The first sentence should be separated from any paragraphs that follow it, and separated with a blank line.
The first sentence should be in straightforward language and an imperative mood.

Example:

def license():
    '''
    Show the Python license in a browser window.
    
    The built-in license function is interactive and blocks the
    UI. We open the default web browser with the Python website
    displaying the license instead.
    '''

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bittner commented

Mar 30, 2019

View reviewed changes

Comment thread

pythonturtle/turtleprocess.py

		if object:
		print(object.__doc__)
		else:
		self.window.show_help()

bittner Mar 30, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work either. For some reason the window has lost some attributes:

>>> help()
Traceback (most recent call last):
  File "/usr/lib/python3.6/code.py", line 91, in runcode
    exec(code, self.locals)
  File "<console>", line 1, in <module>
  File "/home/peter/PythonTurtle/pythonturtle/turtleprocess.py", line 80, in help
    self.window.show_help()
  File "/home/peter/PythonTurtle/pythonturtle/application.py", line 177, in show_help
    self.help_menu_item.Check()
AttributeError: 'ApplicationWindow' object has no attribute 'help_menu_item'

@cool-RR, do you know a way to trigger the "Teach me" button or the <F1> key?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR Mar 30, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try calling ApplicationWindow.show_help?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bittner Mar 30, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the code does, isn't it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR Mar 30, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm a dumbass. I could investigate, but this is very unimportant. You can make it a no-op in the case where an object wasn't specified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR commented Mar 30, 2019

Copy link

Copy Markdown

Member

@bittner Did you get my emails? I'd like to chat with you on Telegram, if you're available.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bittner commented

Mar 30, 2019

View reviewed changes

Comment thread

pythonturtle/turtleprocess.py

		UI. We open the default web browser with the Python website
		displaying the license instead.
		"""
		webbrowser.open('https://docs.python.org/3/license.html')

bittner Mar 30, 2019

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a compromise that does, of course, not work offline. We could try to find out whether the license is available as a file in a Python installation and is somehow accessible for printing out. Otherwise, I'd guess this is acceptable. Who will run this function anyway?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cool-RR Mar 30, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely some very esoteric functionality. Your solution is above and beyond what we need.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bittner commented Mar 30, 2019

Copy link

Copy Markdown

Member Author

1. Triple single quotes instead of triple double quotes.

Let's stick to PEP 257. I can change it accordingly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cool-RR commented Mar 30, 2019

Copy link

Copy Markdown

Member

1. Triple single quotes instead of triple double quotes.
Let's stick to PEP 257. I can change it accordingly.

Compromise: I'm okay with double quotes, but I really hate the lack of space that PEP 257 suggests between the first """ and the first word. Could we do a newline between them like in my example and your current code?

bittner reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bittner commented Mar 31, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Trying a few things and looking at the code after discussing the problem on the wxPython-users Google Group I figured that the problem I'm facing could be related to multiprocessing.

PythonTurtle, when you start it up, is actually running two processes: The main process, hosting all the wxPython business (if I figure correctly), and the TurtleProcess, which is forked as a separate process from the parent process (according to the Unix OS theory).

Could that be why the code behaves weird when I access the window member attached to the TurtleProcess instance? Anything that comes to your mind about this, @cool-RR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cool-RR commented Mar 31, 2019

Copy link

Copy Markdown

Member

Could that be why the code behaves weird when I access the window member attached to the TurtleProcess instance?

This explanation sounds very likely. I think that to implement exit, you'll need to send an "exit" message through a queue similar to the queues defined in console.py, and have code that listens to the message and quits the program. Ensure you're joining the TurtleProcess if that's not done automatically already.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bittner force-pushed the feature/make-disabled-builtins-useful branch from c5fb9a5 to e3520c4 Compare

April 1, 2019 01:15

bittner force-pushed the feature/make-disabled-builtins-useful branch from e3520c4 to bdc6bc0 Compare

August 10, 2019 11:12


          Alternative behavior for exit, help, license builtins

f6a09ec

bittner force-pushed the feature/make-disabled-builtins-useful branch from bdc6bc0 to f6a09ec Compare

August 10, 2019 11:26

Reviewers

cool-RR

cool-RR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

bittner commented Mar 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cool-RR left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cool-RR commented Mar 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bittner commented Mar 30, 2019

Uh oh!

cool-RR commented Mar 30, 2019

Uh oh!

bittner commented Mar 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cool-RR commented Mar 31, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cool-RR left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

bittner commented Mar 31, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.