GeezerVison is showing github.com — Open file branch by Mustang01 · Pull Request #142 · PythonTurtle/PythonTurtle
Conversation
Mustang01
commented
Feb 7, 2020
•
edited by bittner
Loading
Uh oh!
There was an error while loading. Please reload this page.
Adds "Open..." to the file menu, allowing the user to open a file that has python function definitions (only). Includes new help screen to explain how this is used.
Related issues: #64
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
-added functionality to load multiple functions from file
-refactored command formatting, extracted a method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a wonderful idea, great! 👍
- Can you please fix the code style issues? You may want to run
flake8 and pylint, or simply tox locally before you push your changes.
- I'm not convinced whether a newly invented file extension makes sense. Let's stick to
*.py and handle unusable files gracefully. In the end, also in *.ptf files you may have invalid code or unknown functions.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hey, this looks good. I'll take a look at it tomorrow.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hey, I looked at it now. Lots of problems. Thanks @Mustang01 for working on this often-requested feature.
Do fix the code style issues. For example use underscore naming when possible (i.e. save_as instead of saveAs). This is possible whenever we don't interact with wxPython. Use a ".py" extension like Peter said.
I'll try playing around with this feature after you've fixed the issues above.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@Mustang01 Do you have time to fix the issues we addressed? That would allow us to merge your changes. Let us know!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Requested changes must be addressed to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.