GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Properly detect availability of BinaryFormatter by Martin-Molinero · Pull Request #121 · QuantConnect/pythonnet

Conversation

@Martin-Molinero

@Martin-Molinero Martin-Molinero commented Jun 19, 2026

Copy link
Copy Markdown
Member

Cherry-pick from upstream pythonnet/pythonnet: avoids throwing when BinaryFormatter is unavailable (it's removed/disabled on modern .NET, incl. net10). Adds a DefaultFormatterFactory that probes BinaryFormatter once and falls back to NoopFormatter, plus a settable FormatterFactory.

  • Upstream PR: Properly detect availability of BinaryFormatter pythonnet/pythonnet#2639
  • Upstream commit: pythonnet/pythonnet@0258688e (by Benedikt Reinartz)
  • Cherry-picked with -x (original authorship preserved).

Conflict note: RuntimeData.cs diverged in this fork. Resolved by taking the upstream factory and wiring this fork's CreateFormatter() fallback to FormatterFactory() (it previously did new BinaryFormatter() directly, which is what would throw on net10). The FormatterType override path is preserved. Builds clean.

Relevant since this fork targets net10 where BinaryFormatter serialization is no longer supported.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filmor @Martin-Molinero
Properly detect availability of BinaryFormatter (pythonnet#2639)
77bc232 
(cherry picked from commit 0258688)
@jhonabreul

jhonabreul commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Closing, class is completely commented
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jhonabreul jhonabreul closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Martin-Molinero @jhonabreul @filmor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.