GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove RCPP_USING_CXX11 which is now implicit by eddelbuettel · Pull Request #1369 · RcppCore/Rcpp

Conversation

@eddelbuettel

@eddelbuettel eddelbuettel commented Mar 22, 2025

Copy link
Copy Markdown
Member

This PR, under the umbrella of meta issue #1365, builds upon PRs #1367 and #1364. It is a little simpler as it merely removed RCPP_USING_CXX11 wherever it is used (given that it is now always #define'd) and removes the stale #else cases, if any. It all fit into one commit.

A reverse-depends run has been started and is about 100 packages in, this is not expected to reveal anything but we may as well let it run its course again.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eddelbuettel
Remove RCPP_USING_CXX11 which is now implicit
0a2f3a3
@eddelbuettel
eddelbuettel requested review from Enchufa2 and kevinushey March 22, 2025 01:11
@eddelbuettel
Roll micro release and date, update NEWS.Rd
33c6748
Enchufa2
Enchufa2 approved these changes Mar 22, 2025
View reviewed changes

@Enchufa2 Enchufa2 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eddelbuettel reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@eddelbuettel

eddelbuettel commented Mar 24, 2025

Copy link
Copy Markdown
Member Author

This too passed uneventfully, see this commit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eddelbuettel
eddelbuettel merged commit 30edbf5 into master Mar 24, 2025
@eddelbuettel
eddelbuettel deleted the feature/rcpp_using_cxx11 branch March 24, 2025 03:03
@Enchufa2 Enchufa2 mentioned this pull request Mar 24, 2025
C++11 as minimum supported standard #1365
Closed
9 of 14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes
@kevinushey kevinushey Awaiting requested review from kevinushey

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eddelbuettel @Enchufa2
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.